redis: instrumented for tracing and monitoring #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeke-em
force-pushed
the
instrument-with-opencensus
branch
3 times, most recently
from
53023cd
to
4e5ce64
Compare
Instrumented for distributed tracing and monitoring with OpenCensus
Correct the latency measurements to use milliseconds instead of seconds and use a helper function to convert time.Since properly to milliseconds. Also not every connection is a contextAwareDoer so optionally implement that interface.
odeke-em
force-pushed
the
instrument-with-opencensus
branch
from
4e5ce64
to
dde91b9
Compare
|
Hi @odeke-em , |
|
Hi @odeke-em do you still plan to send these changes to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instrumented for distributed tracing and monitoring
with OpenCensus
Given
Server
https://gist.github.com/odeke-em/b4b2c1dc7eddb7199ebc837273316502
Tracing results
Monitoring results