Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete validation for add/edit talk functionality #20

Closed
chartjes opened this issue Jun 3, 2013 · 8 comments
Closed

Complete validation for add/edit talk functionality #20

chartjes opened this issue Jun 3, 2013 · 8 comments
Assignees

Comments

@chartjes
Copy link
Contributor

chartjes commented Jun 3, 2013

The code is all there, just needs to be Implemented the same way the account creation code does it

@pmeth
Copy link
Contributor

pmeth commented Jun 3, 2013

This is probably similar to #26, though that is more specific to a bug.

@zymsys
Copy link
Contributor

zymsys commented Jun 3, 2013

Starting work on this now.

@zymsys
Copy link
Contributor

zymsys commented Jun 4, 2013

I only got as far as looking at the status of this. It is doing validation, but not setting validation error messages. I'll try to get back on it on the train tomorrow morning.

@zymsys
Copy link
Contributor

zymsys commented Jun 4, 2013

Made progress on this. Added tests for validation messages, got tests to pass by adding the messages, still need to make it work in reality. It doesn't seem to validate on edit, and short circuit boolean logic is preventing all validation errors from showing. Maybe I can get that solved after work and before the meetup. See you tonight!

@zymsys
Copy link
Contributor

zymsys commented Jun 11, 2013

I started to merge the latest goodness in with my work, and it was cool - my validators and yours co-existed, so everything validated twice, and my tests failed. Anyway, I think this is resolved now and can be closed?

I can't test in my browser because the URL's are broken. I'm missing mod_rewrite directives. I tried search the repo for 'mod_rewrite' and for 'htaccess' but came up dry. Do we need to add an htaccess file to the repo, or some docs for this? I might have just missed something. I'll check Silex docs in the morning.

@chartjes
Copy link
Contributor Author

Read up on the Silex site on how to configure things for Apache. I didn't
add in a .htaccess file because not everyone who uses it is likely to use
Apache.

I added one in just for my own local repo and put it in web/.htaccess

Options -MultiViews
RewriteEngine On
RewriteCond %{REQUEST_FILENAME} !-f
RewriteRule ^ index.php [QSA,L]

Sorry about this if it screwed you up.

On Mon, Jun 10, 2013 at 8:25 PM, Vic Metcalfe notifications@github.comwrote:

I started to merge the latest goodness in with my work, and it was cool -
my validators and yours co-existed, so everything validated twice, and my
tests failed. Anyway, I think this is resolved now and can be closed?

I can't test in my browser because the URL's are broken. I'm missing
mod_rewrite directives. I tried search the repo for 'mod_rewrite' and for
'htaccess' but came up dry. Do we need to add an htaccess file to the repo,
or some docs for this? I might have just missed something. I'll check Silex
docs in the morning.


Reply to this email directly or view it on GitHubhttps://github.com//issues/20#issuecomment-19234652
.

Chris Hartjes
@grmpyprogrammer
http://www.littlehart.net/atthekeyboard
http://grumpy-testing.com
http://grumpy-phpunit.com

@zymsys
Copy link
Contributor

zymsys commented Jun 11, 2013

Thanks Chris, that will save me some time. I think we should provide this
in some way, either in a .htaccess file, a samples folder with config
files, or in a README.md or INSTALL.md file. It didn't screw me up, I
would have gone to the Silex docs next, but I was out of time for tonight,
and our users (if any) will need this kind of thing too.

Thanks for your help!

Take care,
Vic.

On Mon, Jun 10, 2013 at 8:44 PM, Chris Hartjes notifications@github.comwrote:

Read up on the Silex site on how to configure things for Apache. I didn't
add in a .htaccess file because not everyone who uses it is likely to use
Apache.

I added one in just for my own local repo and put it in web/.htaccess

Options -MultiViews

RewriteEngine On
RewriteCond %{REQUEST_FILENAME} !-f
RewriteRule ^ index.php [QSA,L]

Sorry about this if it screwed you up.

On Mon, Jun 10, 2013 at 8:25 PM, Vic Metcalfe notifications@github.comwrote:

I started to merge the latest goodness in with my work, and it was cool

my validators and yours co-existed, so everything validated twice, and
my
tests failed. Anyway, I think this is resolved now and can be closed?

I can't test in my browser because the URL's are broken. I'm missing
mod_rewrite directives. I tried search the repo for 'mod_rewrite' and
for
'htaccess' but came up dry. Do we need to add an htaccess file to the
repo,
or some docs for this? I might have just missed something. I'll check
Silex
docs in the morning.


Reply to this email directly or view it on GitHub<
https://github.com/chartjes/opencfp/issues/20#issuecomment-19234652>
.

Chris Hartjes
@grmpyprogrammer
http://www.littlehart.net/atthekeyboard
http://grumpy-testing.com
http://grumpy-phpunit.com


Reply to this email directly or view it on GitHubhttps://github.com//issues/20#issuecomment-19235183
.

Vic Metcalfe
(647) 977-5389

@chartjes
Copy link
Contributor Author

For sure we will indicate in the documentation what they need to do.

On Mon, Jun 10, 2013 at 8:47 PM, Vic Metcalfe notifications@github.comwrote:

Thanks Chris, that will save me some time. I think we should provide this
in some way, either in a .htaccess file, a samples folder with config
files, or in a README.md or INSTALL.md file. It didn't screw me up, I
would have gone to the Silex docs next, but I was out of time for tonight,
and our users (if any) will need this kind of thing too.

Thanks for your help!

Take care,
Vic.

On Mon, Jun 10, 2013 at 8:44 PM, Chris Hartjes notifications@github.comwrote:

Read up on the Silex site on how to configure things for Apache. I
didn't
add in a .htaccess file because not everyone who uses it is likely to
use
Apache.

I added one in just for my own local repo and put it in web/.htaccess

Options -MultiViews

RewriteEngine On
RewriteCond %{REQUEST_FILENAME} !-f
RewriteRule ^ index.php [QSA,L]

Sorry about this if it screwed you up.

On Mon, Jun 10, 2013 at 8:25 PM, Vic Metcalfe notifications@github.comwrote:

I started to merge the latest goodness in with my work, and it was

cool

my validators and yours co-existed, so everything validated twice, and
my
tests failed. Anyway, I think this is resolved now and can be closed?

I can't test in my browser because the URL's are broken. I'm missing
mod_rewrite directives. I tried search the repo for 'mod_rewrite' and
for
'htaccess' but came up dry. Do we need to add an htaccess file to the
repo,
or some docs for this? I might have just missed something. I'll check
Silex
docs in the morning.


Reply to this email directly or view it on GitHub<
https://github.com/chartjes/opencfp/issues/20#issuecomment-19234652>
.

Chris Hartjes
@grmpyprogrammer
http://www.littlehart.net/atthekeyboard
http://grumpy-testing.com
http://grumpy-phpunit.com


Reply to this email directly or view it on GitHub<
https://github.com/chartjes/opencfp/issues/20#issuecomment-19235183>
.

Vic Metcalfe
(647) 977-5389


Reply to this email directly or view it on GitHubhttps://github.com//issues/20#issuecomment-19235304
.

Chris Hartjes
@grmpyprogrammer
http://www.littlehart.net/atthekeyboard
http://grumpy-testing.com
http://grumpy-phpunit.com

@ghost ghost assigned zymsys and chartjes Jun 11, 2013
chartjes added a commit that referenced this issue Jun 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants