-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete validation for add/edit talk functionality #20
Comments
This is probably similar to #26, though that is more specific to a bug. |
Starting work on this now. |
I only got as far as looking at the status of this. It is doing validation, but not setting validation error messages. I'll try to get back on it on the train tomorrow morning. |
Made progress on this. Added tests for validation messages, got tests to pass by adding the messages, still need to make it work in reality. It doesn't seem to validate on edit, and short circuit boolean logic is preventing all validation errors from showing. Maybe I can get that solved after work and before the meetup. See you tonight! |
I started to merge the latest goodness in with my work, and it was cool - my validators and yours co-existed, so everything validated twice, and my tests failed. Anyway, I think this is resolved now and can be closed? I can't test in my browser because the URL's are broken. I'm missing mod_rewrite directives. I tried search the repo for 'mod_rewrite' and for 'htaccess' but came up dry. Do we need to add an htaccess file to the repo, or some docs for this? I might have just missed something. I'll check Silex docs in the morning. |
Read up on the Silex site on how to configure things for Apache. I didn't I added one in just for my own local repo and put it in web/.htaccess Options -MultiViews
Sorry about this if it screwed you up. On Mon, Jun 10, 2013 at 8:25 PM, Vic Metcalfe notifications@github.comwrote:
Chris Hartjes |
Thanks Chris, that will save me some time. I think we should provide this Thanks for your help! Take care, On Mon, Jun 10, 2013 at 8:44 PM, Chris Hartjes notifications@github.comwrote:
Vic Metcalfe |
For sure we will indicate in the documentation what they need to do. On Mon, Jun 10, 2013 at 8:47 PM, Vic Metcalfe notifications@github.comwrote:
Chris Hartjes |
The code is all there, just needs to be Implemented the same way the account creation code does it
The text was updated successfully, but these errors were encountered: