date time improvements #452
Conversation
classes/Domain/CallForProposal.php
Outdated
| @@ -2,7 +2,9 @@ | |||
|
|
|||
| namespace OpenCFP\Domain; | |||
|
|
|||
| use DateTime; | |||
| use DateTimeInterface; | |||
There was a problem hiding this comment.
please reorder your use statements in alphabetical order to prevent triggering the Code Sniffer error ordered_imports in Travis.
tests/ApplicationTest.php
Outdated
| @@ -3,6 +3,7 @@ | |||
| namespace OpenCFP\Test; | |||
|
|
|||
| use OpenCFP\Application; | |||
| use OpenCFP\Domain\CallForProposal; | |||
There was a problem hiding this comment.
this is unused. did you forget to add something? if not, please remove it to prevent Travis from triggering the Code Sniffer error no_unused_imports.
| @@ -38,7 +38,7 @@ public function register(Application $app) | |||
| if ($enddate->format('H:i:s') == '00:00:00') { | |||
There was a problem hiding this comment.
the $enddate variable is no longer used and should be removed.
There was a problem hiding this comment.
I'm going to merge this into the Silex 2.0 branch and clean up any of the CS errors
|
Ugh, @heiglandreas could you redo this PR against the new master? |
This commit adds the logic to set the end of the day when only a date is provided to the CallForProposal-class
This commit moves more checks whether a CfP is open to the CallForProposal-class. For that the class is registered as a service to be easily callable.
These changes where necessary to adapt to the new master. It's a rebase with solved conflicts
This commit introduces changes required by CS-Fixer
heiglandreas
force-pushed
the
hotfix/DateTime
branch
from
b70806b
to
2c97ae3
Compare
|
@chartjes: Rebases and solved conflicts. All tests are green on my machine 😉. |
heiglandreas
force-pushed
the
hotfix/DateTime
branch
from
cf08692
to
8b611e5
Compare
The statement was altered to be able to use sqlite in development. As sqlite doesn't understand the ```database()```-command I needed to use something else… This commit reintroduces the old query to work on travis
heiglandreas
force-pushed
the
hotfix/DateTime
branch
from
8b611e5
to
9709e90
Compare
|
Thanks @heiglandreas |
|
I removed that |
|
@heiglandreas Yeah, I saw but somehow I messed it up. I pushed code again and tests pass now |
This PR adds some more datetime-improvements by moving the
isOpen-checks all to theCallForProposal-class. For that there's a new servicecallforproposalregistered in the app.Follows #450 and #451.