Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Use type declaration #828

Merged
merged 1 commit into from Dec 5, 2017
Merged

Fix: Use type declaration #828

merged 1 commit into from Dec 5, 2017

Conversation

localheinz
Copy link
Contributor

This PR

  • uses a type declaration

@localheinz localheinz added the bug label Dec 3, 2017
localheinz
localheinz commented Dec 3, 2017
View reviewed changes
classes/Domain/Speaker/SpeakerRepository.php
@@ -21,13 +21,13 @@
/**
* Retrieves a speaker with associated talks.
*
* @param string $speakerId
* @param int $speakerId
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using int everywhere as identifiers.

@mdwheele mdwheele merged commit a9bbd8a into opencfp:master Dec 5, 2017
@localheinz localheinz deleted the fix/more-type branch December 5, 2017 06:57
@localheinz
Copy link
Contributor Author

Thank you, @mdwheele!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdwheele mdwheele mdwheele approved these changes

Assignees

@mdwheele mdwheele

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@localheinz @mdwheele