Turned RequestCleaner into an event subscriber #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
request-cleaner-listener
branch
from
6ddc659
to
d63b4f3
Compare
|
Looking good, can you resolve the conflicts, please? |
derrabus
force-pushed
the
request-cleaner-listener
branch
2 times, most recently
from
7b4c121
to
5df77db
Compare
|
Done. |
localheinz
reviewed
Dec 7, 2017
| @@ -333,5 +332,8 @@ public function subscribe(Container $app, EventDispatcherInterface $dispatcher) | |||
| $app[CsrfValidator::class], | |||
| $app['url_generator'] | |||
| )); | |||
| $dispatcher->addSubscriber(new RequestCleanerListener( | |||
| $app['purifier'] | |||
There was a problem hiding this comment.
Ha, sorry - can we sort out the wrapping issue here as well, please?
derrabus
force-pushed
the
request-cleaner-listener
branch
from
5df77db
to
ee5ef08
Compare
|
Thank you, @derrabus! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RequestCleanerclass is now an event subscriber too.Related to #618.