Added AbstractSystemProperty and 4 system properties implementation. #203
Conversation
|
@amihaiemil Please check this commit :D |
| this.name = name; | ||
| } | ||
|
|
||
| @Override |
There was a problem hiding this comment.
@SherifWaly Indentation to the left here
| public StEsEndPoint(final String name) { | ||
| super(name); | ||
| } | ||
|
|
There was a problem hiding this comment.
@SherifWaly For this, can you override the read() method, to check if the endpoint ends with "/" or not? If not, then add it. So:
public String read() {
String endpoint = super.read()
//... check for '/' here
}
|
@SherifWaly As you probably noticed, interfaces For instance, when instantiating a SignedRequest or an EsHttpRequest, you will clearly see that they expect a Also, we will have a few decorators, both for generic Makes sense? What do you think? |
| * @version $Id$ | ||
| * @since 1.0.0 | ||
| */ | ||
| public final class StAccessKeyId extends AbstractSystemProperty implements SecretKey { |
There was a problem hiding this comment.
@SherifWaly Here, implements AccessKeyId
| * @version $Id$ | ||
| * @since 1.0.0 | ||
| */ | ||
| public final class StRegion extends AbstractSystemProperty implements SecretKey { |
There was a problem hiding this comment.
@SherifWaly Here, implements Region
There was a problem hiding this comment.
@amihaiemil Sorry for this mistake.
| @Override | ||
| public String read() { | ||
| String endPoint = super.read(); | ||
| if(!endPoint.endsWith("\\")) { |
There was a problem hiding this comment.
@SherifWaly We need "/" (slash), not "\" (backslash) :D Sorry, I might have written it wrong when I let the comment the first time.
There was a problem hiding this comment.
@amihaiemil Ok, I've made a new commit :D
|
@amihaiemil Please check last commit :) |
|
@rultor pls merge |
@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here |
@amihaiemil Done! FYI, the full log is here (took me 3min) |
PR for #201