Fix $select on primitive collection #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When implementing $orderby the aggregation for a collection was broken into two peices this meant we needed to convert the column data back to JSON in the aggregate function if its an object otherwise we end up with an array of string encoded json objects. This only applies to objects though, so we need to skip the conversion if building an aggregate of primitive types.
ghost
force-pushed
the
fix_primitve_collection
branch
from
a837d1b
to
0d98a7a
Compare
FrimIdan
approved these changes
Mar 14, 2023
akpsgit
approved these changes
Mar 14, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When implementing $orderby the aggregation for a collection was broken into two peices this meant we needed to convert the column data back to JSON in the aggregate function if its an object otherwise we end up with an array of string encoded json objects. This only applies to objects though, so we need to skip the conversion if building an aggregate of primitive types.
Type of Change
[X] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist