Move default for maxParallelScanners out of ScanConfigData #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
as a 
akpsgit
previously approved these changes
Mar 19, 2023
A value can not have a default and also be readOnly because the default gets applied if the value is unset so then you are implictly trying to write it as the default. This moves the default to the ScanConfig object which is used for reading/writing, and out of ScanConfigData which is shared by ScanConfigRelationship and needs all the fields to be readOnly.
akpsgit
force-pushed
the
fix_readonly_max_scanners
branch
from
80258b5
to
22603df
Compare
akpsgit
approved these changes
Mar 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A value can not have a default and also be readOnly because the default gets applied if the value is unset so then you are implictly trying to write it as the default.
This moves the default to the ScanConfig object which is used for reading/writing, and out of ScanConfigData which is shared by ScanConfigRelationship and needs all the fields to be readOnly.
Type of Change
[X] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist