Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make grype timeouts configurable #1751

Merged
merged 2 commits into from
May 31, 2024
Merged

Conversation

zsoltkacsandi
Copy link
Contributor

@zsoltkacsandi zsoltkacsandi commented May 29, 2024

Description

There is a known issue with grype, it occasionally get stuck when a new database version is published:

anchore/grype#1731

To solve this problem, timeouts of the HTTP client have been made configurable:

anchore/grype@7c849c3

This PR allows VMClarity users to configure these timeouts.

Type of Change

[ ] Bug Fix
[X] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@zsoltkacsandi zsoltkacsandi requested a review from a team as a code owner May 29, 2024 10:03
@zsoltkacsandi zsoltkacsandi self-assigned this May 29, 2024

This comment has been minimized.

paralta
paralta previously approved these changes May 29, 2024
Copy link
Contributor

@paralta paralta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work here 👍

Copy link

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr1751-f4d0cc94b7baf6befaa28d76236016d79c41db2c
  • ghcr.io/openclarity/vmclarity-cli-dev:pr1751-f4d0cc94b7baf6befaa28d76236016d79c41db2c
  • ghcr.io/openclarity/vmclarity-cr-discovery-server-dev:pr1751-f4d0cc94b7baf6befaa28d76236016d79c41db2c
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr1751-f4d0cc94b7baf6befaa28d76236016d79c41db2c
  • ghcr.io/openclarity/vmclarity-plugin-kics-dev:pr1751-f4d0cc94b7baf6befaa28d76236016d79c41db2c
  • ghcr.io/openclarity/vmclarity-ui-dev:pr1751-f4d0cc94b7baf6befaa28d76236016d79c41db2c
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr1751-f4d0cc94b7baf6befaa28d76236016d79c41db2c

@zsoltkacsandi zsoltkacsandi added this pull request to the merge queue May 31, 2024
Merged via the queue into main with commit c519566 May 31, 2024
40 checks passed
@zsoltkacsandi zsoltkacsandi deleted the set-grype-scanner-timeouts branch May 31, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants