Allow setting VMClarity images in CloudFormation template #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
suggested changes
Mar 22, 2023
There was a problem hiding this comment.
hey @chrisgacsal, thanks for the PR. I've left a couple of comments.
Also right now VMClarity doesn't use conventional commits, there is no need for "feat" etc in the commit message/PR headlines. For now please keep them human readable/presentable as they'll be directly inserted in the change log as is.
chrisgacsal
force-pushed
the
add-img-param-to-cf
branch
from
656c7f7
to
9f3cd0d
Compare
chrisgacsal
changed the title
ghost
suggested changes
Mar 22, 2023
chrisgacsal
force-pushed
the
add-img-param-to-cf
branch
from
9f3cd0d
to
e9cb6ae
Compare
chrisgacsal
force-pushed
the
add-img-param-to-cf
branch
from
e9cb6ae
to
5d84ec5
Compare
ghost
approved these changes
Mar 22, 2023
There was a problem hiding this comment.
Looks good, thanks @chrisgacsal!
This made me realise that we probably need to add a "cfn-lint" step in the CI to make sure that the cloud formation in PRs are valid, I've opened a ticket for this.
Make VMClarity container images configurable in CloudFormation template.
ghost
force-pushed
the
add-img-param-to-cf
branch
from
5d84ec5
to
32d01df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow setting VMClarity images in CloudFormation template.
Type of Change
[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[x] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist