Propagate context.Context to operations with support for it #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisgacsal
force-pushed
the
refactor-ctx-in-cli
branch
from
55398bf
to
181d0f2
Compare
chrisgacsal
force-pushed
the
refactor-ctx-in-cli
branch
from
181d0f2
to
f147f85
Compare
FrimIdan
reviewed
Mar 23, 2023
chrisgacsal
force-pushed
the
refactor-ctx-in-cli
branch
2 times, most recently
from
ad028b1
to
bf4562c
Compare
FrimIdan
previously approved these changes
Mar 23, 2023
Use a single context.Context tree by propagating ctx to functions interacting with external resources, although there are couple operations that do not support context.Context yet.
chrisgacsal
force-pushed
the
refactor-ctx-in-cli
branch
from
e7e340e
to
6060cd2
Compare
pbalogh-sa
approved these changes
Mar 23, 2023
shalevr
added a commit
that referenced
this pull request
Mar 28, 2023
* main: (31 commits) Improve error messages and add missing comments in Lynis scanner Add lynis scanner to the misconfiguration family fix nil summary crash in Region findings widget (#194) Switch result processor vulnerabilties map print to debug level (#192) UI dashboard (#191) set disabled to true for a non periodic scan once scan started Add infrastructure for scan result post processing (#136) Add a new DB error type for validation errors (#189) Findings trends dashboard widget (#182) Fix odata queries for TargetScanResult/Status (#184) UI null fields (#188) Fix exporter check in waitFroAttached Malware family and ClamAV implementation (#118) Propagate Context (#181) Add support for comparing datetimes to odatasql Most risky assets dashboard widget (#172) Make sure that scan init failures are captured by scan state (#144) UI config updates new (#180) Fix error message in misconfiguration family Add missing misconfiguration scan scanners field ... # Conflicts: # cli/cmd/exportresults.go # cli/cmd/root.go # runtime_scan/pkg/config/config.go # runtime_scan/pkg/scanner/job_managment.go
shalevr
added a commit
that referenced
this pull request
Mar 28, 2023
* main: (31 commits) Improve error messages and add missing comments in Lynis scanner Add lynis scanner to the misconfiguration family fix nil summary crash in Region findings widget (#194) Switch result processor vulnerabilties map print to debug level (#192) UI dashboard (#191) set disabled to true for a non periodic scan once scan started Add infrastructure for scan result post processing (#136) Add a new DB error type for validation errors (#189) Findings trends dashboard widget (#182) Fix odata queries for TargetScanResult/Status (#184) UI null fields (#188) Fix exporter check in waitFroAttached Malware family and ClamAV implementation (#118) Propagate Context (#181) Add support for comparing datetimes to odatasql Most risky assets dashboard widget (#172) Make sure that scan init failures are captured by scan state (#144) UI config updates new (#180) Fix error message in misconfiguration family Add missing misconfiguration scan scanners field ... # Conflicts: # cli/cmd/exportresults.go # cli/cmd/root.go # runtime_scan/pkg/config/config.go # runtime_scan/pkg/scanner/job_managment.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use a single
context.Contexttree by propagating ctx to functions interacting with external resources, although there are couple operations that do not supportcontext.Contextyet.Type of Change
[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[x] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist