fix(plugin): add healthz check retry mechanism #1820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
ramizpolic
reviewed
Jun 19, 2024
Signed-off-by: András Jáky <ajaky@cisco.com>
Signed-off-by: András Jáky <ajaky@cisco.com>
akijakya
force-pushed
the
plugin-health-check-retry-mechanism
branch
from
1b5b98e
to
c519400
Compare
Signed-off-by: András Jáky <ajaky@cisco.com>
|
Hey! Your images are ready:
|
zsoltkacsandi
approved these changes
Jun 20, 2024
ramizpolic
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of exiting with an error, print out the error message and continue with the retries in case checking the plugin's healthz endpoint fails.
There might be cases when the server is not yet ready to accept connections.
Type of Change
Checklist