-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add img/logos directory and vmclarity logo to README #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
suggested changes
Mar 29, 2023
ghost
changed the title
Add img/logos directory and vmclarity logo
Add img/logos directory and vmclarity logo to README
Mar 31, 2023
FrimIdan
previously approved these changes
Apr 2, 2023
ghost
previously approved these changes
Apr 3, 2023
shmcfarl
commented
Apr 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Cleans up all the logo filenames to remove whitespace. It also fixes the light-bg files which were incorrectly named. The README has been updated to use the <picture> tags so that light mode and dark mode images can be served based on the viewers theme.
ghost
approved these changes
Apr 3, 2023
ghost
deleted the
img-logos
branch
April 3, 2023 14:50
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created a new sub-directory for images (img) and logos (logos). I added the VMClarity logo to the header of the README.md file.
Type of Change
[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[X] Documentation
[ ] Other (please describe)