Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add img/logos directory and vmclarity logo to README #201

Merged
5 commits merged into from
Apr 3, 2023
Merged

Add img/logos directory and vmclarity logo to README #201

5 commits merged into from
Apr 3, 2023

Conversation

shmcfarl
Copy link
Contributor

Description

Created a new sub-directory for images (img) and logos (logos). I added the VMClarity logo to the header of the README.md file.

Type of Change

[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[X] Documentation
[ ] Other (please describe)

@shmcfarl shmcfarl requested a review from a team as a code owner March 28, 2023 16:40
README.md Outdated Show resolved Hide resolved
@ghost ghost changed the title Add img/logos directory and vmclarity logo Add img/logos directory and vmclarity logo to README Mar 31, 2023
FrimIdan
FrimIdan previously approved these changes Apr 2, 2023
ghost
ghost previously approved these changes Apr 3, 2023
@galiail galiail dismissed stale reviews from ghost and FrimIdan via 874dee5 April 3, 2023 08:06
@ghost ghost enabled auto-merge (rebase) April 3, 2023 10:56
Copy link
Contributor Author

@shmcfarl shmcfarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shmcfarl and others added 5 commits April 3, 2023 15:26
Cleans up all the logo filenames to remove whitespace. It also fixes the
light-bg files which were incorrectly named.

The README has been updated to use the <picture> tags so that light mode
and dark mode images can be served based on the viewers theme.
@ghost ghost merged commit c115368 into main Apr 3, 2023
5 checks passed
@ghost ghost deleted the img-logos branch April 3, 2023 14:50
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants