Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix sortby logic and refactor BuildSQLQuery ut #210

Merged
merged 2 commits into from
Mar 30, 2023
Merged

fix sortby logic and refactor BuildSQLQuery ut #210

merged 2 commits into from
Mar 30, 2023

Conversation

FrimIdan
Copy link
Member

Description

fix sortby logic and refactor BuildSQLQuery ut

Type of Change

[X] Bug Fix
[ ] New Feature
[ ] Breaking Change
[X] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@FrimIdan FrimIdan self-assigned this Mar 29, 2023
@FrimIdan FrimIdan requested a review from a team as a code owner March 29, 2023 15:53
ghost
ghost previously approved these changes Mar 30, 2023
View reviewed changes
@FrimIdan FrimIdan enabled auto-merge (rebase) March 30, 2023 07:08
@FrimIdan FrimIdan requested a review from a user March 30, 2023 07:29
@FrimIdan FrimIdan merged commit a884ce2 into main Mar 30, 2023
@FrimIdan FrimIdan deleted the sortby-fix branch March 30, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees

@FrimIdan FrimIdan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@FrimIdan