-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Exporter in CLI #230
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisgacsal
force-pushed
the
refactor-cli
branch
from
April 3, 2023 19:45
4e3e35e
to
5a67b71
Compare
ghost
suggested changes
Apr 4, 2023
FrimIdan
reviewed
Apr 4, 2023
chrisgacsal
force-pushed
the
refactor-cli
branch
5 times, most recently
from
April 5, 2023 07:38
2b3378d
to
6a805d2
Compare
chrisgacsal
force-pushed
the
refactor-cli
branch
4 times, most recently
from
April 5, 2023 12:51
380b95b
to
426ce34
Compare
ghost
suggested changes
Apr 5, 2023
chrisgacsal
force-pushed
the
refactor-cli
branch
from
April 5, 2023 15:57
426ce34
to
9a466c6
Compare
chrisgacsal
force-pushed
the
refactor-cli
branch
from
April 6, 2023 06:19
9a466c6
to
60aedf1
Compare
ghost
previously approved these changes
Apr 6, 2023
chrisgacsal
force-pushed
the
refactor-cli
branch
from
April 6, 2023 14:23
60aedf1
to
f4bf215
Compare
ghost
previously approved these changes
Apr 6, 2023
chrisgacsal
force-pushed
the
refactor-cli
branch
from
April 6, 2023 14:37
9424ea2
to
d3cf575
Compare
ghost
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Split logic implemented by
Exporter
intostate.Manager
andpresenter.Presenter
interfaces to separate responsibilities of managing state of the TargetScan (e.g. moving its status to InProgress) and how the scan results are presented (e.g. pulished to VMClarity API, written to console/file, etc.). These two interfaces are grouped together in thecli.CLI
making the functionality provided both available via a single object.State
The
state.Manager
has two implementations:state.VMClarity
stores state updates to the VMClarity APIstate.Local
is responsible to store/manage state locallyPresenter
The
presenter.Presenter
has the following implementations:presenter.ConsolePresenter
allows printing scan results to the terminal/consolepresenter.FilePresenter
saves scan results to filespresenter.MultiPresenter
allows combining multiplepresenter.Presenter
implementationspresenter.VMClarityPresenter
responsible for publishing scan results to the VMClarity APIType of Change
[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[x] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist