Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update scan config watcher window to include also operation times before now but within window/2 time frame #233

Merged
merged 3 commits into from
Apr 4, 2023

Conversation

FrimIdan
Copy link
Member

@FrimIdan FrimIdan commented Apr 4, 2023

Description

To better support the scan now option in the UI the window to check the operation time needed to be updated to run a scan also if the operation time is in the past but within a window/2 time frame. (after now - window/2 and before now + window/2)

Type of Change

[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[X] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@FrimIdan FrimIdan requested a review from a team as a code owner April 4, 2023 08:13
ghost
ghost previously approved these changes Apr 4, 2023
pbalogh-sa
pbalogh-sa previously approved these changes Apr 4, 2023
## Description

UI - save table sort

## Type of Change

[ ] Bug Fix  
[x] New Feature  
[ ] Breaking Change  
[ ] Refactor  
[ ] Documentation  
[ ] Other (please describe)
@FrimIdan FrimIdan dismissed stale reviews from pbalogh-sa and ghost via 2623b0b April 4, 2023 09:18
@FrimIdan FrimIdan enabled auto-merge (squash) April 4, 2023 09:18
@FrimIdan FrimIdan requested review from pbalogh-sa and a user April 4, 2023 09:19
@FrimIdan FrimIdan merged commit 01361d5 into main Apr 4, 2023
5 checks passed
@FrimIdan FrimIdan deleted the fix-scan-config-watcher-window branch April 4, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants