Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update delete job policy and change default #236

Merged
merged 1 commit into from
Apr 9, 2023

Conversation

ghost
Copy link

@ghost ghost commented Apr 4, 2023

Description

It also makes it configurable in the cloud formation for the developer workflow.

Type of Change

[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[X] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@ghost ghost self-requested a review as a code owner April 4, 2023 10:03
@ghost ghost force-pushed the change_default_delete_policy branch from f3efa97 to e35a864 Compare April 4, 2023 10:04
FrimIdan
FrimIdan previously approved these changes Apr 4, 2023
akpsgit
akpsgit previously approved these changes Apr 4, 2023
@ghost ghost dismissed stale reviews from akpsgit and FrimIdan via ae0c337 April 5, 2023 08:27
It also makes it configurable in the cloud formation for the developer
workflow.
@FrimIdan FrimIdan force-pushed the change_default_delete_policy branch from ae0c337 to 3f15a70 Compare April 9, 2023 08:04
@FrimIdan FrimIdan enabled auto-merge (rebase) April 9, 2023 08:05
@FrimIdan FrimIdan merged commit c0b04e9 into main Apr 9, 2023
5 checks passed
@FrimIdan FrimIdan deleted the change_default_delete_policy branch April 9, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants