Make filter and orderby work for fields that need to be expanded #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
filter_on_expanded
branch
from
2e9b64d
to
82e1bb9
Compare
ghost
changed the title
ghost
marked this pull request as ready for review
ghost
force-pushed
the
filter_on_expanded
branch
2 times, most recently
from
6aae23d
to
6a5f4ca
Compare
akpsgit
reviewed
Apr 13, 2023
With this change if you put a field in $filter or $orderby which requires expansion, the underlying query will expand it. This works regardless of whether the field is $expand in the returned data.
ghost
force-pushed
the
filter_on_expanded
branch
from
6a5f4ca
to
75dce72
Compare
pbalogh-sa
approved these changes
Apr 14, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this change if you put a field in $filter or $orderby which requires expansion, the underlying query will expand it. This works regardless of whether the field is $expand in the returned data.
Type of Change
[ ] Bug Fix
[X] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist