Make CLI write reports to file for scanner jobs #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Change is good, but I think the description needs a tweak, this doesn't change the default in the CLI, it changes the scanner job. |
chrisgacsal
changed the title
@sambetts-cisco Updated the description for the PR. |
chrisgacsal
force-pushed
the
cli-report-to-file
branch
2 times, most recently
from
6c71bf6
to
3442986
Compare
ghost
approved these changes
Apr 14, 2023
ghost
suggested changes
Apr 14, 2023
chrisgacsal
force-pushed
the
cli-report-to-file
branch
from
3442986
to
d5e74ef
Compare
chrisgacsal
force-pushed
the
cli-report-to-file
branch
2 times, most recently
from
fbf566a
to
4cf4729
Compare
chrisgacsal
force-pushed
the
cli-report-to-file
branch
from
4cf4729
to
17703de
Compare
pbalogh-sa
approved these changes
Apr 18, 2023
ghost
approved these changes
Apr 18, 2023
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the CLI writes reports to the console by default which might make sense when the CLI is used locally. However it makes hard to spot issues/errors at runtime for scanner jobs as it pollutes the logs with the reports of the scanners.
This change makes the the scanner job to write the scanner reports to files at path provided via
--outputcommand line parameter.Type of Change
[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[x] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist