Handle upgrade of cloud formation with different defaults #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrimIdan
reviewed
Apr 24, 2023
ghost
force-pushed
the
cfn_upgrade_fixes
branch
from
6a09f73
to
11b1a6a
Compare
When you deploy a cloud formation stack, even if you leave the default parameters the values are saved. When you upgrade the saved values are used instead of the defaults, which means that if we change the container version in the default for a parameter it gets ignored on upgrade. This commit changes the symantics of the parameters to overrides, only if provided will they override the value which we set in the CFN template. This means that: - if you want to return to the default value you can delete the contents of the parameter. - during upgrades the cloud formation will template in the new values unless an override is provided.
ghost
force-pushed
the
cfn_upgrade_fixes
branch
from
11b1a6a
to
07873cf
Compare
chrisgacsal
approved these changes
Apr 25, 2023
ghost
enabled auto-merge
fishkerez
pushed a commit
that referenced
this pull request
May 1, 2023
## Description When you deploy a cloud formation stack, even if you leave the default parameters the values are saved. When you upgrade the saved values are used instead of the defaults, which means that if we change the container version in the default for a parameter it gets ignored on upgrade. This commit changes the symantics of the parameters to overrides, only if provided will they override the value which we set in the CFN template. This means that: - if you want to return to the default value you can delete the contents of the parameter. - during upgrades the cloud formation will template in the new values unless an override is provided. ## Type of Change [X] Bug Fix [ ] New Feature [ ] Breaking Change [X] Refactor [ ] Documentation [ ] Other (please describe) ## Checklist - [X] I have read the [contributing guidelines](/CONTRIBUTING.md) - [X] Existing issues have been referenced (where applicable) - [X] I have verified this change is not present in other open pull requests - [X] Functionality is documented - [X] All code style checks pass - [X] New code contribution is covered by automated tests - [X] All new and existing tests pass
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When you deploy a cloud formation stack, even if you leave the default parameters the values are saved.
When you upgrade the saved values are used instead of the defaults, which means that if we change the container version in the default for a parameter it gets ignored on upgrade.
This commit changes the symantics of the parameters to overrides, only if provided will they override the value which we set in the CFN template. This means that:
if you want to return to the default value you can delete the contents of the parameter.
during upgrades the cloud formation will template in the new values unless an override is provided.
Type of Change
[X] Bug Fix
[ ] New Feature
[ ] Breaking Change
[X] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist