Add revision number to VMClarity objects and support for If-Match header #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
etags
branch
2 times, most recently
from
f901996
to
6cdc8cb
Compare
ghost
marked this pull request as ready for review
akpsgit
reviewed
May 7, 2023
akpsgit
reviewed
May 7, 2023
akpsgit
previously approved these changes
May 17, 2023
FrimIdan
reviewed
May 18, 2023
FrimIdan
previously approved these changes
May 18, 2023
FrimIdan
previously approved these changes
May 22, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
This adds a revision number to every VMClarity API object, this number can be used as an eTag in the API through the If-Match header to ensure that we avoid "lost update" issues while reconciling objects.
Adds new helper functions which handle checking the revision against IfMatch and also bumps the revision or sets the initial value if its not set.
FrimIdan
approved these changes
Jun 1, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a revision number to every VMClarity API object, this number can be used as an eTag in the API through the If-Match header to ensure that we avoid "lost update" issues while reconciling objects.
Type of Change
[ ] Bug Fix
[X] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist