Remove go.mod from subpackages except API and fix Makefile #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrimIdan
reviewed
Jan 17, 2023
akpsgit
reviewed
Jan 17, 2023
ghost
force-pushed
the
cleanup_linters_and_mods
branch
from
fe29d3e
to
9b04815
Compare
This commit removes the go.mod from the subpackages runtime_scan and backend as they import each other in multiple places resulting in managing the same set of dependecies in three different places. Once these go.mods are removed then the Makefile targets for linting, fixing and testing can be cleaned up significantly and all packages treated as one module. This commit also fixes an issue in the docker targets which results in the cli and backend containers getting tagged with the same image name "vmclarity" when they should be "vmclarity-cli" and "vmclarity-backend". One final change is that the Dockerfiles have been updated to use the buildkit caches for the go compilations which speed us local docker build times significantly.
ghost
force-pushed
the
cleanup_linters_and_mods
branch
from
9b04815
to
eb654c3
Compare
FrimIdan
approved these changes
Jan 18, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the go.mod from the subpackages runtime_scan and backend as they import each other in multiple places resulting in managing the same set of dependecies in three different places.
Once these go.mods are removed then the Makefile targets for linting, fixing and testing can be cleaned up significantly and all packages treated as one module.
This commit also fixes an issue in the docker targets which results in the cli and backend containers getting tagged with the same image name "vmclarity" when they should be "vmclarity-cli" and "vmclarity-backend".
One final change is that the Dockerfiles have been updated to use the buildkit caches for the go compilations which speed us local docker build times significantly.