Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add creation of vmclarity cli docker image on arm64 architecture #362

Merged
merged 3 commits into from
Jun 2, 2023

Conversation

adamtagscherer
Copy link
Contributor

@adamtagscherer adamtagscherer commented Jun 1, 2023

Description

In this PR I added multi-arch build to the Dockerfile.cli.
With this PR merged in, we will be able to run the scanner on amd64 and arm64 architectures.

docker specific env vars:
https://docs.docker.com/engine/reference/commandline/buildx_build/#platform
https://docs.docker.com/engine/reference/builder/#automatic-platform-args-in-the-global-scope

Type of Change

[ ] Bug Fix
[x] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@adamtagscherer adamtagscherer requested a review from a team as a code owner June 1, 2023 14:34
Copy link
Contributor

@chrisgacsal chrisgacsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@adamtagscherer adamtagscherer linked an issue Jun 2, 2023 that may be closed by this pull request
@adamtagscherer adamtagscherer added this pull request to the merge queue Jun 2, 2023
Merged via the queue into main with commit 0ad53c9 Jun 2, 2023
5 checks passed
@adamtagscherer adamtagscherer deleted the vmclarity-cli-arm64-image branch June 2, 2023 11:16
@adamtagscherer adamtagscherer self-assigned this Jun 23, 2023
@adamtagscherer adamtagscherer added enhancement New feature or request docker Pull requests that update Docker code github actions Pull requests that update GitHub Actions code labels Jun 23, 2023
@adamtagscherer adamtagscherer modified the milestones: v0.5.0, v0.6.0 Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Pull requests that update Docker code enhancement New feature or request github actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support arm architecture with docker images
2 participants