Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dont build multiarch locally #381

Merged
merged 1 commit into from
Jun 8, 2023
Merged

fix: dont build multiarch locally #381

merged 1 commit into from
Jun 8, 2023

Conversation

adamtagscherer
Copy link
Contributor

@adamtagscherer adamtagscherer commented Jun 8, 2023 •
edited

Description

  • added a digest to the vmclarity-cli base image
  • fix makefile to not fail on local multiarch build

Type of Change

[x] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@adamtagscherer adamtagscherer requested a review from a team as a code owner June 8, 2023 11:47
@chrisgacsal chrisgacsal added this pull request to the merge queue Jun 8, 2023
Merged via the queue into main with commit fc97d14 Jun 8, 2023
5 checks passed
@chrisgacsal chrisgacsal deleted the remove-makefile-multi-arch branch June 8, 2023 14:58
@adamtagscherer adamtagscherer self-assigned this Jun 23, 2023
@adamtagscherer adamtagscherer added docker Pull requests that update Docker code bug Something isn't working labels Jun 23, 2023
@adamtagscherer adamtagscherer linked an issue Jun 23, 2023 that may be closed by this pull request
Support arm architecture with docker images #367
Closed
@adamtagscherer adamtagscherer modified the milestones: v0.5.0, v0.6.0 Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisgacsal chrisgacsal chrisgacsal approved these changes

@FrimIdan FrimIdan FrimIdan approved these changes

Assignees

@adamtagscherer adamtagscherer

Labels
bug Something isn't working docker Pull requests that update Docker code
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.

Support arm architecture with docker images
3 participants
@adamtagscherer @chrisgacsal @FrimIdan