refactor: add delayed startup of Controllers #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisgacsal
force-pushed
the
reduce-polling-interval
branch
from
26957c5
to
7456fe6
Compare
Make Orchestrator to wait for a predefined time period before starting each Controller to avoid them hitting the API at the same time and allow one Controller to pick up an event generated by the other without waiting until the next polling cycle.
chrisgacsal
force-pushed
the
reduce-polling-interval
branch
from
7456fe6
to
97af6a5
Compare
ghost
previously approved these changes
Jun 9, 2023
ghost
approved these changes
Jun 9, 2023
akpsgit
reviewed
Jun 11, 2023
| ) | ||
|
|
||
| type Config struct { | ||
| AWSConfig *aws.Config | ||
| ScannerBackendAddress string | ||
|
|
||
| // The Orchestrator starts the Controller(s) in a sequence and the ControllerStartupDelay is used for waiting |
There was a problem hiding this comment.
Saw that it was merged but maybe worth stating in the comment that the delay is between controller starts (just for users not to be confused why the first one starts without a delay). "..used for waiting between Controller starts to ..."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make
Orchestratorto wait for a predefined time period before starting eachControllerto avoid them hitting the API at the same time and allow oneControllerto pick up an event generated by the other without waiting until the next polling cycle.Type of Change
[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[x] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist