Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: provider configuration #388

Merged
merged 4 commits into from
Jun 14, 2023
Merged

refactor: provider configuration #388

merged 4 commits into from
Jun 14, 2023

Conversation

chrisgacsal
Copy link
Contributor

@chrisgacsal chrisgacsal commented Jun 9, 2023 •
edited

Description

Refactor

  • removed Provider specific configuration form orchestrator.Config
  • added VMCLARITY_AWS prefix to environment variables related to aws package
  • switch from using viper.Get* getters to viper.Unmarshal to initialize aws.Config

Documentation

  • extended documentation with the configuration options for Orchestrator and Provider components.

Type of Change

[ ] Bug Fix
[ ] New Feature
[x] Breaking Change
[x] Refactor
[x] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@chrisgacsal chrisgacsal requested a review from a team as a code owner June 9, 2023 16:41
@chrisgacsal chrisgacsal self-assigned this Jun 9, 2023
@chrisgacsal chrisgacsal added the enhancement New feature or request label Jun 9, 2023
@chrisgacsal chrisgacsal changed the title refactor: mv AWS specific config refactor: move AWS specific config Jun 9, 2023
@chrisgacsal chrisgacsal marked this pull request as draft June 9, 2023 16:48
@chrisgacsal chrisgacsal changed the title refactor: move AWS specific config feat: add multi-arch support to AWS provider Jun 10, 2023
@chrisgacsal chrisgacsal force-pushed the refactor-provider-config branch 3 times, most recently from beaff45 to 9b1a9f9 Compare June 10, 2023 22:17
@chrisgacsal chrisgacsal marked this pull request as ready for review June 10, 2023 22:21
@chrisgacsal chrisgacsal force-pushed the refactor-provider-config branch 3 times, most recently from 51c76f2 to d51e445 Compare June 10, 2023 23:07
@chrisgacsal
Copy link
Contributor Author

I've verified the changes by running E2E test with success.

@chrisgacsal chrisgacsal mentioned this pull request Jun 11, 2023
Merged
@chrisgacsal chrisgacsal force-pushed the refactor-provider-config branch 3 times, most recently from 90dff43 to 46d600b Compare June 13, 2023 15:28
@chrisgacsal chrisgacsal changed the title feat: add multi-arch support to AWS provider refactor: provider configuration Jun 13, 2023
@chrisgacsal
Copy link
Contributor Author

I've verified the changes by re-running E2E test with success.

@chrisgacsal chrisgacsal mentioned this pull request Jun 13, 2023
Draft
7 tasks
ghost
ghost suggested changes Jun 14, 2023
View reviewed changes
runtime_scan/pkg/provider/aws/config.go Outdated Show resolved Hide resolved
installation/aws/VmClarity.cfn Show resolved Hide resolved
runtime_scan/pkg/provider/aws/client.go Show resolved Hide resolved
runtime_scan/pkg/provider/aws/config.go Outdated Show resolved Hide resolved
runtime_scan/pkg/provider/aws/config.go Show resolved Hide resolved
FrimIdan
FrimIdan reviewed Jun 14, 2023
View reviewed changes
runtime_scan/pkg/orchestrator/config.go Outdated Show resolved Hide resolved
runtime_scan/pkg/orchestrator/config.go Outdated Show resolved Hide resolved
@chrisgacsal chrisgacsal requested review from FrimIdan and a user June 14, 2023 12:51
@chrisgacsal chrisgacsal added this pull request to the merge queue Jun 14, 2023
Merged via the queue into main with commit fbd40fd Jun 14, 2023
5 checks passed
@chrisgacsal chrisgacsal deleted the refactor-provider-config branch June 14, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagikazarmark sagikazarmark sagikazarmark left review comments

@FrimIdan FrimIdan Awaiting requested review from FrimIdan

Assignees

@chrisgacsal chrisgacsal

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chrisgacsal @sagikazarmark @FrimIdan