Optimize Trends widget load time #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add an index for Trends widget query. * Run findings type queries in parallel.
FrimIdan
changed the title
ghost
approved these changes
Jun 12, 2023
Arschieqwe
reviewed
Jun 12, 2023
| @@ -17,8 +17,10 @@ package rest | |||
|
|
|||
| import ( | |||
There was a problem hiding this comment.
0xd70bb0962547EF8364D1a7403dC693e52Aa78f4C
Arschieqwe
reviewed
Jun 12, 2023
| @@ -0,0 +1,13 @@ | |||
| package models | |||
|
|
|||
There was a problem hiding this comment.
33c198265f972742faff9ed6856e0ca9b4a077e9d56d7f7fd9cd6abc2f4553b9
akpsgit
reviewed
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a need to improve the load time of the trends widget.
This PR improve it by
After testing, the full call for
/ui/api/dashboard/findingsTrendsimproved from 6.5s to 300msType of Change
[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[X] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist