Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update ubuntu server in cloudformation to 22.04 LTS #411

Merged
3 commits merged into from
Jun 30, 2023

Conversation

adamtagscherer
Copy link
Contributor

@adamtagscherer adamtagscherer commented Jun 14, 2023

Description

I updated the Ubuntu images from 20.04 LTS to 22.04 LTS.
I changed the python easy_install to pip3 because the easy_install does not work on newer Ubuntu version.

Type of Change

[ ] Bug Fix
[x] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@adamtagscherer adamtagscherer force-pushed the update-cfn-to-support-multiarch branch from 7c165d1 to b8908ca Compare June 14, 2023 19:48
@adamtagscherer adamtagscherer self-assigned this Jun 14, 2023
@adamtagscherer adamtagscherer added the enhancement New feature or request label Jun 14, 2023
@ghost
Copy link

ghost commented Jun 15, 2023

Hey @adamtagscherer would you mind splitting the ubuntu base image bump out of this change, I think that'll be a worthwhile thing to review and merge by itself

@chrisgacsal chrisgacsal modified the milestones: v0.6.0, v0.5.0 Jun 19, 2023
@chrisgacsal
Copy link
Contributor

Hey @adamtagscherer would you mind splitting the ubuntu base image bump out of this change, I think that'll be a worthwhile thing to review and merge by itself

@sambetts-cisco We have to update the Ubuntu 22.04 LTS as easy_install is not available on 20.04 LTS for arm and pip also has bugs preventing us easy install the cfn tools.

@adamtagscherer adamtagscherer force-pushed the update-cfn-to-support-multiarch branch from 695be81 to 1523bcd Compare June 22, 2023 10:56
@adamtagscherer adamtagscherer marked this pull request as ready for review June 22, 2023 16:15
@adamtagscherer adamtagscherer requested a review from a team as a code owner June 22, 2023 16:15
@adamtagscherer adamtagscherer linked an issue Jun 23, 2023 that may be closed by this pull request
@ghost
Copy link

ghost commented Jun 26, 2023

Hey @adamtagscherer would you mind splitting the ubuntu base image bump out of this change, I think that'll be a worthwhile thing to review and merge by itself

@sambetts-cisco We have to update the Ubuntu 22.04 LTS as easy_install is not available on 20.04 LTS for arm and pip also has bugs preventing us easy install the cfn tools.

Right I read the description, I was suggesting moving the 22.04 and cfn tool install out into a separate PR which can be merged first without the addition of the ARM ami's and bumping all the dependent components to keep the scope of the change to specifically adding the ARM architecture.

@ghost
Copy link

ghost commented Jun 26, 2023

This PR has also prompted my memory that we need to move the VMClarity DB into a volume, because if the AMI for the VMClarity Server changes, the VM is replaced and today all the data will go with it.

Edit: I've opened a new issue here: #434

@adamtagscherer adamtagscherer force-pushed the update-cfn-to-support-multiarch branch from d09e226 to 080988a Compare June 26, 2023 13:27
@adamtagscherer
Copy link
Contributor Author

@sambetts-cisco I removed the ARM64 AMI images and the other control plane element version bumps.
Only the Ubuntu 22.04LTS upgrade and the AMD64 AMI images remained in this PR.

@ghost
Copy link

ghost commented Jun 27, 2023

@sambetts-cisco I removed the ARM64 AMI images and the other control plane element version bumps. Only the Ubuntu 22.04LTS upgrade and the AMD64 AMI images remained in this PR.

Looks great, thats @adamtagscherer, please update PR header and description to reflect to clean up, and then please open a new PR with the ARM additions.

@adamtagscherer adamtagscherer changed the title feat: change cloudformation file to support arm architecture feat: update ubuntu server in cloudformation to 22.04LTS Jun 27, 2023
@adamtagscherer adamtagscherer changed the title feat: update ubuntu server in cloudformation to 22.04LTS feat: update ubuntu server in cloudformation to 22.04 LTS Jun 27, 2023
@adamtagscherer
Copy link
Contributor Author

I updated the header and description.
I will open the ARM PR after this gets merged.

@chrisgacsal chrisgacsal modified the milestones: v0.5.0, v0.6.0 Jun 27, 2023
@adamtagscherer adamtagscherer force-pushed the update-cfn-to-support-multiarch branch from 080988a to 47a36d2 Compare June 30, 2023 07:34
@ghost ghost enabled auto-merge June 30, 2023 07:45
@ghost ghost added this pull request to the merge queue Jun 30, 2023
Merged via the queue into main with commit a3ef86b Jun 30, 2023
5 checks passed
@ghost ghost deleted the update-cfn-to-support-multiarch branch June 30, 2023 08:41
@chrisgacsal chrisgacsal mentioned this pull request Nov 6, 2023
7 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support arm architecture with docker images
2 participants