fix: multiarch docker image #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamtagscherer
added
bug
adamtagscherer
force-pushed
the
fix-multiarch-dockerfile
branch
from
9fe8f0e
to
118bb8b
Compare
adamtagscherer
force-pushed
the
fix-multiarch-dockerfile
branch
from
ffa268b
to
1a9143b
Compare
ramizpolic
approved these changes
Jun 21, 2023
adamtagscherer
added a commit
that referenced
this pull request
Jun 29, 2023
* fix: multiarch docker image * fix: remove binutils gold * fix: add binutils gold to xx-apk * fix: add binutils to xx-apk * fix: remove binutils to xx-apk * fix: try refactoring Dockerfile and see if CI runs successfully * fix: add binutils-gold * fix: add binutils-gold explicit version * fix: add binutils-gold explicit version * fix: add binutils-cross * fix: add binutils with explicit version * fix: bump build-push-action, remove cache * fix: remove cache * fix: add qemu to github actions * fix: update github actions * fix: switch to debian based builder platform * fix: arrange Dockerfile.backend * documentation: add comment * refactor: move CGO to env, wrap go, remove mounts * fix: pass static flag to external linker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The multiarch Docker image doesn't work on crosscompiled platforms (arm64 in this case because we build on amd64).
With this PR merged in, it will work on amd64 and arm64 as well.
After a couple days of digging, I ended up using the following repository: https://github.com/tonistiigi/xx
This is an utility image that helps installing the proper cross compiling tools for the target platform.
Type of Change
[x] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist