fix: ScanResults stuck in aborted state #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisgacsal
added
bug
chrisgacsal
force-pushed
the
fix-abort-timeout
branch
3 times, most recently
from
a206f6a
to
bc6f05e
Compare
fishkerez
reviewed
Jun 26, 2023
chrisgacsal
force-pushed
the
fix-abort-timeout
branch
from
bc6f05e
to
e3242b3
Compare
chrisgacsal
force-pushed
the
fix-abort-timeout
branch
from
e3242b3
to
ec2aa25
Compare
|
I've verified the change by running E2E on AWS. |
The `vmclarity-cli` running on the `Scanner` instance is responsible for handling the `aborted` event for the corresponding `ScanResult`. The `ScanResultWatcher` controller will periodically check whether the `vmclarity-cli` managed to gracefully shutdown the running scan and set the` ScanResult `to `done` indicating that thr scan is finished and the Scanner instance could be removed. However moving the `ScanResults` state to `done` will not happen in case the `vmclarity-cli` process is not running on the Scanner instance making the `ScanResultWatcher` controller waiting indefinitely. The `ScanResultWatcher` will now monitor the `ScanResults` in `aborted` state and will move their state to `done` after a predefined period of time.
chrisgacsal
force-pushed
the
fix-abort-timeout
branch
from
ec2aa25
to
05a3612
Compare
ghost
approved these changes
Jun 30, 2023
ghost
added this pull request to the
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
vmclarity-clirunning on theScannerinstance is responsible for handling theabortedevent for the correspondingScanResult. TheScanResultWatchercontroller will periodically check whether thevmclarity-climanaged to gracefully shutdown the running scan and set theScanResulttodoneindicating that thr scan is finished and the Scanner instance could be removed. However moving theScanResultsstate todonewill not happen in case thevmclarity-cliprocess is not running on the Scanner instance making theScanResultWatchercontroller waiting indefinitely.The
ScanResultWatcherwill now monitor theScanResultsinabortedstate and will move their state todoneafter a predefined period of time.Type of Change
[x] Bug Fix
[ ] New Feature
[ ] Breaking Change
[x] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist