Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add provider for Google Cloud Platform #433

Merged
7 commits merged into from
Jul 17, 2023
Merged

feat: Add provider for Google Cloud Platform #433

7 commits merged into from
Jul 17, 2023

Conversation

fishkerez
Copy link
Contributor

Description

Add support for GCP provider. This is the code part, without the installation, which should come next.

Type of Change

[ ] Bug Fix
[ *] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • [* ] I have read the contributing guidelines
  • [ *] Existing issues have been referenced (where applicable)
  • [ *] I have verified this change is not present in other open pull requests
  • [ *] Functionality is documented
  • [ *] All code style checks pass
  • [ *] New code contribution is covered by automated tests
  • [ *] All new and existing tests pass

@fishkerez fishkerez requested a review from a team as a code owner June 25, 2023 13:21
@fishkerez fishkerez self-assigned this Jun 25, 2023
FrimIdan
FrimIdan reviewed Jun 27, 2023
View reviewed changes
api/openapi.yaml Outdated Show resolved Hide resolved
runtime_scan/pkg/orchestrator/scanconfigwatcher/watcher.go Outdated Show resolved Hide resolved
runtime_scan/pkg/orchestrator/scanconfigwatcher/watcher.go Outdated Show resolved Hide resolved
runtime_scan/pkg/provider/gcp/client.go Outdated Show resolved Hide resolved
runtime_scan/pkg/provider/gcp/client.go Outdated Show resolved Hide resolved
runtime_scan/pkg/provider/gcp/common.go Outdated Show resolved Hide resolved
runtime_scan/pkg/provider/gcp/config.go Outdated Show resolved Hide resolved
runtime_scan/pkg/provider/gcp/scannerVm.go Show resolved Hide resolved
runtime_scan/pkg/provider/gcp/scannerVm.go Outdated Show resolved Hide resolved
runtime_scan/pkg/provider/gcp/snapshot.go Outdated Show resolved Hide resolved
chrisgacsal
chrisgacsal previously requested changes Jun 27, 2023
View reviewed changes
runtime_scan/pkg/provider/cloudinit/cloud-init.tmpl.yaml Outdated Show resolved Hide resolved
runtime_scan/pkg/provider/aws/client.go Outdated Show resolved Hide resolved
runtime_scan/pkg/provider/gcp/config.go Outdated Show resolved Hide resolved
runtime_scan/pkg/provider/gcp/config.go Outdated Show resolved Hide resolved
runtime_scan/pkg/provider/gcp/scannerVm.go Outdated Show resolved Hide resolved
runtime_scan/pkg/provider/gcp/scannerVm.go Outdated Show resolved Hide resolved
runtime_scan/pkg/provider/gcp/scannerVm.go Outdated Show resolved Hide resolved
runtime_scan/pkg/orchestrator/scanconfigwatcher/watcher.go Outdated Show resolved Hide resolved
runtime_scan/pkg/provider/gcp/client_test.go Show resolved Hide resolved
@chrisgacsal chrisgacsal added this to the v0.6.0 milestone Jun 27, 2023
@ghost ghost force-pushed the gcp_support branch 2 times, most recently from ebaefa6 to b9e2ac3 Compare July 13, 2023 13:42
@ghost ghost changed the title gcp support feat: add GCP provider Jul 13, 2023
@ghost ghost changed the title feat: add GCP provider feat: Add provider for Google Cloud Platform Jul 13, 2023
@ghost ghost dismissed chrisgacsal’s stale review July 13, 2023 14:12

Issues have been resolved or are no longer relevant.

ghost
ghost approved these changes Jul 14, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this E2E on GCP with the GCP installer and its working as expected. I'll approve however I contributed to the PR so I'd like to have at least one other approver before merging.

@ghost ghost enabled auto-merge July 17, 2023 13:20
@ghost ghost added this pull request to the merge queue Jul 17, 2023
Merged via the queue into main with commit 374e34f Jul 17, 2023
5 checks passed
@ghost ghost deleted the gcp_support branch July 17, 2023 14:22
@ghost ghost mentioned this pull request Jul 19, 2023
Closed
@chrisgacsal chrisgacsal mentioned this pull request Nov 6, 2023
Merged
7 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisgacsal chrisgacsal chrisgacsal left review comments

@FrimIdan FrimIdan FrimIdan left review comments

Assignees

@fishkerez fishkerez

Labels
None yet
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fishkerez @chrisgacsal @FrimIdan @Tehsmash