-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add GCP installer using GCP Deployment Manager #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fishkerez
reviewed
Jul 11, 2023
fishkerez
reviewed
Jul 11, 2023
Did not see any scanners network/firewall rules, the way we have in the rest of the providers (private network vs public and so on..). Is that on purpose? |
ghost
marked this pull request as ready for review
July 12, 2023 15:06
ghost
self-requested a review
as a code owner
July 12, 2023 15:06
fishkerez
reviewed
Jul 13, 2023
pbalogh-sa
reviewed
Jul 13, 2023
fishkerez
reviewed
Jul 13, 2023
fishkerez
reviewed
Jul 13, 2023
fishkerez
reviewed
Jul 13, 2023
pbalogh-sa
previously approved these changes
Jul 13, 2023
ghost
changed the title
Add GCP Deployment Manager installer
feat: Add GCP installer using GCP Deployment Manager
Jul 13, 2023
ghost
enabled auto-merge
July 17, 2023 13:19
This commit adds a GCP installer for VMClarity which uses the GCP deployment manager. It creates: * A new VPC for VMClarity, configures and runs the VMClarity server in the choosen zone within that VPC. * A static IP is created to allow for SSH into the VMClarity server. * A service account and roles are created to allow VMClarity to discover and scan the instances in GCP.
ghost
requested a review
from fishkerez
July 19, 2023 10:32
ghost
mentioned this pull request
Jul 19, 2023
Closed
fishkerez
approved these changes
Jul 20, 2023
ghost
added this pull request to the merge queue
Jul 20, 2023
ghost
deleted the
gcp_installer
branch
July 20, 2023 11:22
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit adds GCP Cloud Deployment Manager as a new method for installing VMClarity.
Type of Change
[ ] Bug Fix
[X] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist