Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add GCP installer using GCP Deployment Manager #449

Merged
1 commit merged into from
Jul 20, 2023
Merged

Conversation

ghost
Copy link

@ghost ghost commented Jul 6, 2023

Description

This commit adds GCP Cloud Deployment Manager as a new method for installing VMClarity.

Type of Change

[ ] Bug Fix
[X] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@fishkerez
Copy link
Contributor

Did not see any scanners network/firewall rules, the way we have in the rest of the providers (private network vs public and so on..). Is that on purpose?

@ghost ghost marked this pull request as ready for review July 12, 2023 15:06
@ghost ghost self-requested a review as a code owner July 12, 2023 15:06
pbalogh-sa
pbalogh-sa previously approved these changes Jul 13, 2023
@ghost ghost changed the title Add GCP Deployment Manager installer feat: Add GCP installer using GCP Deployment Manager Jul 13, 2023
@ghost ghost enabled auto-merge July 17, 2023 13:19
This commit adds a GCP installer for VMClarity which uses the GCP
deployment manager. It creates:

* A new VPC for VMClarity, configures and runs the VMClarity server in
  the choosen zone within that VPC.

* A static IP is created to allow for SSH into the VMClarity server.

* A service account and roles are created to allow VMClarity to discover
  and scan the instances in GCP.
@ghost ghost requested a review from fishkerez July 19, 2023 10:32
@ghost ghost mentioned this pull request Jul 19, 2023
@ghost ghost added this pull request to the merge queue Jul 20, 2023
Merged via the queue into main with commit 068bc39 Jul 20, 2023
5 checks passed
@ghost ghost deleted the gcp_installer branch July 20, 2023 11:22
@chrisgacsal chrisgacsal mentioned this pull request Nov 6, 2023
7 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants