Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docker): create docker provider #462

Merged
merged 38 commits into from
Jul 27, 2023
Merged

feat(docker): create docker provider #462

merged 38 commits into from
Jul 27, 2023

Conversation

adamtagscherer
Copy link
Contributor

@adamtagscherer adamtagscherer commented Jul 12, 2023 •
edited

Description

This PR creates the docker provider which lets us to scan containers and images downloaded to the local registry.
After this PR is merged in we can move to creating the E2E tests.

Type of Change

[ ] Bug Fix
[x] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@adamtagscherer adamtagscherer added enhancement New feature or request docker Pull requests that update Docker code go Pull requests that update Go code labels Jul 12, 2023
@adamtagscherer adamtagscherer added this to the v0.6.0 milestone Jul 12, 2023
@adamtagscherer adamtagscherer linked an issue Jul 12, 2023 that may be closed by this pull request
Docker Container and Image Provider #405
Closed
ramizpolic
ramizpolic reviewed Jul 12, 2023
View reviewed changes
cli/cmd/root.go Outdated Show resolved Hide resolved
ramizpolic and others added 19 commits July 27, 2023 16:00
@ramizpolic @paralta
feat: standardize docker asset discovery
82187ca 
Signed-off-by: Ramiz Polic <ramiz.polic@hotmail.com>
@paralta
feat(docker): Create new bridge network to run scan container
0e95e16
@paralta
feat(docker): Code review changes
925a740
@paralta
feat(docker): Code review changes
180ba73
@adamtagscherer @paralta
refactor(docker): break down entrypoint script, add comment to docker…
1c72df3 
… image pull
@paralta
Fix asset type switch case
061cb2b
@paralta
feat(docker): Add volume mount point as input in family configuration
c8398a8
@adamtagscherer @paralta
refactor(docker): remove docker config
828408d
@paralta
feat(docker): Clean up and remove container location
db563f4
@paralta
feat(docker): Fix verification errors
494871d
@ramizpolic @paralta
feat: simplify docker provider flow
51c09e6 
Signed-off-by: Ramiz Polic <ramiz.polic@hotmail.com>
@paralta
feat(docker): Code review changes
ed98833
@paralta
feat(docker): Fix CI verification
fb0e18e
@paralta
feat(docker): network changes for scanner container
c917977
@paralta
feat(docker): fix create volume success return
5d3eb0a
@paralta
feat(docker): change yaml package to fix families config marshalling
d6e8611
@adamtagscherer @paralta
refactor(docker): parse constants with viper
5487d70
@adamtagscherer @paralta
refactor(docker): move default values to constants
1f4bcac
@adamtagscherer @paralta
fix(docker): format with gofumpt
9647411
@paralta paralta dismissed stale reviews from ghost and ramizpolic via 9647411 July 27, 2023 15:00
@paralta paralta enabled auto-merge July 27, 2023 15:09
@paralta paralta added this pull request to the merge queue Jul 27, 2023
Merged via the queue into main with commit bd41dbd Jul 27, 2023
5 checks passed
@paralta paralta deleted the docker-provider branch July 27, 2023 16:02
@chrisgacsal chrisgacsal mentioned this pull request Nov 6, 2023
Merged
7 tasks
@chrisgacsal chrisgacsal mentioned this pull request Feb 21, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paralta paralta paralta left review comments

@fishkerez fishkerez fishkerez left review comments

@ramizpolic ramizpolic ramizpolic approved these changes

@chrisgacsal chrisgacsal Awaiting requested review from chrisgacsal

Assignees

@adamtagscherer adamtagscherer

@paralta paralta

Labels
docker Pull requests that update Docker code enhancement New feature or request go Pull requests that update Go code
Projects
OpenClarity
Status: Done
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.

Docker Container and Image Provider
5 participants
@adamtagscherer @ramizpolic @paralta @chrisgacsal @fishkerez