Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit IDs in API #49

Merged
merged 8 commits into from
Feb 9, 2023
Merged

Revisit IDs in API #49

merged 8 commits into from
Feb 9, 2023

Conversation

pbalogh-sa
Copy link
Member

Need to distinguish unique constraints conflict and existing ID objects

@pbalogh-sa pbalogh-sa changed the title Revisit IDs Revisit IDs in API Jan 25, 2023
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're slightly abusing the returns from the DB right now by using returned item and the err. I've got a suggestion for pushing the control down to the DB layer for the conflicts please take a look

backend/pkg/rest/scan_config_controller.go Outdated Show resolved Hide resolved
ghost
ghost previously approved these changes Feb 3, 2023
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
@pbalogh-sa pbalogh-sa merged commit 8208ea0 into main Feb 9, 2023
@pbalogh-sa pbalogh-sa deleted the revisit-ids branch February 9, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants