Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add interactive API explorer to VMClarity #496

Merged
1 commit merged into from
Aug 8, 2023
Merged

feat: add interactive API explorer to VMClarity #496

1 commit merged into from
Aug 8, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jul 25, 2023

Description

This adds an interactive API explorer using swagger-ui to VMClarity
based on our openapi spec.

image
image

Type of Change

[ ] Bug Fix
[X] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@ghost ghost marked this pull request as ready for review August 2, 2023 16:45
@ghost ghost self-requested a review as a code owner August 2, 2023 16:45
@ghost ghost force-pushed the swagger_api_ui branch 2 times, most recently from 0ab2362 to 33ec6d2 Compare August 3, 2023 09:19
Copy link
Member

@FrimIdan FrimIdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great @sambetts-cisco , can you please attache to the PR a screenshot of the new button and the try-it-now example?

installation/aws/VmClarity.cfn Outdated Show resolved Hide resolved
pkg/apiserver/rest/common.go Outdated Show resolved Hide resolved
This adds an interactive API explorer using swagger-ui to VMClarity
based on our openapi spec.
Copy link
Contributor

@chrisgacsal chrisgacsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment, otherwise LGTM! Thanks for the effort.

pkg/apiserver/rest/common.go Show resolved Hide resolved
pkg/apiserver/rest/common.go Show resolved Hide resolved
@ghost ghost added this pull request to the merge queue Aug 8, 2023
Merged via the queue into main with commit 879e97e Aug 8, 2023
8 checks passed
@ghost ghost deleted the swagger_api_ui branch August 8, 2023 07:52
@chrisgacsal chrisgacsal mentioned this pull request Nov 6, 2023
7 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants