Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(test): add end to end tests skeleton and some basic tests #539

Merged
merged 44 commits into from
Aug 28, 2023
Merged

feat(test): add end to end tests skeleton and some basic tests #539

merged 44 commits into from
Aug 28, 2023

Conversation

paralta
Copy link
Contributor

@paralta paralta commented Aug 8, 2023 •
edited

Description

#333

Type of Change

[ ] Bug Fix
[x] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@paralta paralta mentioned this pull request Aug 9, 2023
Merged
7 tasks
@paralta paralta added invalid This doesn't seem right test enhancement New feature or request and removed invalid This doesn't seem right labels Aug 9, 2023
@paralta paralta force-pushed the vm-clarity-e-2-e-tests branch 4 times, most recently from 1894c78 to d397a9a Compare August 9, 2023 18:04
@paralta paralta marked this pull request as ready for review August 10, 2023 09:47
@paralta paralta requested a review from a team as a code owner August 10, 2023 09:47
ghost
ghost reviewed Aug 10, 2023
View reviewed changes
end_to_end_test/suite_test.go Outdated Show resolved Hide resolved
end_to_end_test/testenv/logging.go Outdated Show resolved Hide resolved
ramizpolic
ramizpolic reviewed Aug 10, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
ramizpolic
ramizpolic previously approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@ramizpolic ramizpolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Side note: will e2e run as a pipeline step?

@paralta
Copy link
Contributor Author

paralta commented Aug 11, 2023

@ramizpolic thank you so much for reviewing! The plan is to initially run the tests in the pipeline but to not gate any merging. Once we are happy with the test reliability, we can change this.
The runtime is currently less than 6min which would be acceptable given that our current time to merge is around 35min.

FrimIdan
FrimIdan reviewed Aug 13, 2023
View reviewed changes
e2e/abort_scan_test.go Outdated Show resolved Hide resolved
ghost
ghost reviewed Aug 14, 2023
View reviewed changes
e2e/helpers.go Outdated Show resolved Hide resolved
installation/docker/dockercompose.yml Outdated Show resolved Hide resolved
installation/docker/dockercompose.yml Outdated Show resolved Hide resolved
installation/docker/dockercompose.yml Show resolved Hide resolved
@paralta paralta force-pushed the vm-clarity-e-2-e-tests branch 2 times, most recently from 698e4d7 to 6a4c19c Compare August 16, 2023 14:15
@paralta paralta linked an issue Aug 17, 2023 that may be closed by this pull request
End to end test skeleton + 1 example test case #333
Closed
@chrisgacsal chrisgacsal self-requested a review August 28, 2023 13:06
chrisgacsal
chrisgacsal approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@chrisgacsal chrisgacsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the E2E locally and it works like charm. Thanks a lot for the effort @paralta! This is huge! :shipit:

@chrisgacsal chrisgacsal added this pull request to the merge queue Aug 28, 2023
Merged via the queue into main with commit 186971f Aug 28, 2023
8 checks passed
@chrisgacsal chrisgacsal deleted the vm-clarity-e-2-e-tests branch August 28, 2023 15:49
@paralta paralta mentioned this pull request Aug 29, 2023
Merged
7 tasks
@chrisgacsal chrisgacsal mentioned this pull request Nov 6, 2023
Merged
7 tasks
@chrisgacsal chrisgacsal mentioned this pull request Feb 21, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrimIdan FrimIdan FrimIdan left review comments

@fishkerez fishkerez fishkerez left review comments

@chrisgacsal chrisgacsal chrisgacsal approved these changes

@ramizpolic ramizpolic ramizpolic left review comments

@Tehsmash Tehsmash Awaiting requested review from Tehsmash

Assignees

@adamtagscherer adamtagscherer

@paralta paralta

Labels
enhancement New feature or request test
Projects
OpenClarity
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

End to end test skeleton + 1 example test case
7 participants
@paralta @Tehsmash @chrisgacsal @ramizpolic @FrimIdan @fishkerez @adamtagscherer