Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(orchestrator): skip mark terminated if asset found but patch failed #614

Merged
merged 1 commit into from
Sep 6, 2023
Merged

fix(orchestrator): skip mark terminated if asset found but patch failed #614

merged 1 commit into from
Sep 6, 2023

Conversation

paralta
Copy link
Contributor

@paralta paralta commented Aug 31, 2023

Description

#447

Type of Change

[x] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@paralta paralta added the bug Something isn't working label Aug 31, 2023
@paralta paralta requested a review from a team as a code owner August 31, 2023 12:23
@paralta paralta self-assigned this Aug 31, 2023
@paralta paralta linked an issue Aug 31, 2023 that may be closed by this pull request
Do not mark asset terminated if we found it but failed to patch #447
Closed
@paralta paralta force-pushed the issue447-patch-fail branch 3 times, most recently from bb1fa2a to f3d8862 Compare September 4, 2023 13:23
chrisgacsal
chrisgacsal approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@chrisgacsal chrisgacsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix.

@paralta paralta added this pull request to the merge queue Sep 6, 2023
@chrisgacsal chrisgacsal removed this pull request from the merge queue due to a manual request Sep 6, 2023
@chrisgacsal chrisgacsal added this pull request to the merge queue Sep 6, 2023
Merged via the queue into main with commit f3a933d Sep 6, 2023
9 checks passed
@chrisgacsal chrisgacsal deleted the issue447-patch-fail branch September 6, 2023 12:53
@chrisgacsal chrisgacsal mentioned this pull request Nov 6, 2023
Merged
7 tasks
@chrisgacsal chrisgacsal mentioned this pull request Feb 21, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisgacsal chrisgacsal chrisgacsal approved these changes

Assignees

@paralta paralta

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not mark asset terminated if we found it but failed to patch
2 participants
@paralta @chrisgacsal