fix export crushing when family fail to run #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrimIdan
reviewed
Feb 5, 2023
akpsgit
reviewed
Feb 5, 2023
akpsgit
previously approved these changes
Feb 5, 2023
akpsgit
approved these changes
Feb 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when a family fail to run, we return error and nil results.
that causing a crash when we try to export these results to the backend, since we try to access the nil results.
This PR fixes this crush, and also:
Currently we don't try to run all the families in case that one is failed. Need to save the error and go to the next one. At the end export the results and the family errors, together with a general error that at least one of the families failed.