Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(scanresult): resource cleanup status refactor #689

Merged
merged 15 commits into from
Sep 29, 2023
Merged

feat(scanresult): resource cleanup status refactor #689

merged 15 commits into from
Sep 29, 2023

Conversation

adamtagscherer
Copy link
Contributor

@adamtagscherer adamtagscherer commented Sep 13, 2023 •
edited

Description

Updates the ResourceCleanupState for the new object, and also enforces the proper state transitions when the API is called.

related issue: #664

Type of Change

[x] Bug Fix
[ ] New Feature
[ ] Breaking Change
[x] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@adamtagscherer adamtagscherer requested a review from a team as a code owner September 13, 2023 08:22
@adamtagscherer adamtagscherer self-assigned this Sep 13, 2023
@adamtagscherer adamtagscherer added bug Something isn't working enhancement New feature or request go Pull requests that update Go code component:api Issues related to API labels Sep 13, 2023
@adamtagscherer adamtagscherer added this to the v0.6.0 milestone Sep 13, 2023
@adamtagscherer adamtagscherer linked an issue Sep 13, 2023 that may be closed by this pull request
Status object refactor in the API #664
Closed
chrisgacsal
chrisgacsal requested changes Sep 14, 2023
View reviewed changes
api/models/state.go Outdated Show resolved Hide resolved
pkg/apiserver/database/gorm/asset_scan.go Outdated Show resolved Hide resolved
pkg/apiserver/rest/asset_scan_controller.go Outdated Show resolved Hide resolved
pkg/apiserver/rest/asset_scan_controller.go Outdated Show resolved Hide resolved
pkg/orchestrator/assetscanwatcher/watcher.go Show resolved Hide resolved
pkg/orchestrator/assetscanwatcher/watcher.go Outdated Show resolved Hide resolved
@adamtagscherer adamtagscherer force-pushed the resouce-cleanup-state-refactor branch 2 times, most recently from 8b78c6a to 91f4a25 Compare September 20, 2023 14:51
@chrisgacsal chrisgacsal changed the title feat(scanresult): resource cleanup state refactor feat(scanresult): resource cleanup status refactor Sep 21, 2023
chrisgacsal
chrisgacsal previously approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@chrisgacsal chrisgacsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

chrisgacsal
chrisgacsal requested changes Sep 25, 2023
View reviewed changes
pkg/apiserver/rest/asset_scan_controller.go Outdated Show resolved Hide resolved
pkg/apiserver/rest/asset_scan_controller.go Outdated Show resolved Hide resolved
fishkerez
fishkerez reviewed Sep 26, 2023
View reviewed changes
api/models/status.go Outdated Show resolved Hide resolved
pkg/orchestrator/assetscanwatcher/watcher.go Outdated Show resolved Hide resolved
pkg/orchestrator/assetscanwatcher/watcher.go Outdated Show resolved Hide resolved
api/models/status.go Outdated Show resolved Hide resolved
api/models/status.go Outdated Show resolved Hide resolved
api/models/assetscan.go Outdated Show resolved Hide resolved
@paralta paralta mentioned this pull request Sep 26, 2023
Merged
7 tasks
chrisgacsal
chrisgacsal previously approved these changes Sep 29, 2023
View reviewed changes
@adamtagscherer adamtagscherer added this pull request to the merge queue Sep 29, 2023
@adamtagscherer adamtagscherer removed this pull request from the merge queue due to a manual request Sep 29, 2023
@adamtagscherer adamtagscherer added this pull request to the merge queue Sep 29, 2023
Merged via the queue into main with commit 3cd9e93 Sep 29, 2023
10 checks passed
@adamtagscherer adamtagscherer deleted the resouce-cleanup-state-refactor branch September 29, 2023 12:33
@adamtagscherer adamtagscherer removed a link to an issue Oct 16, 2023
Status object refactor in the API #664
Closed
@chrisgacsal chrisgacsal mentioned this pull request Nov 6, 2023
Merged
7 tasks
@chrisgacsal chrisgacsal mentioned this pull request Feb 21, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisgacsal chrisgacsal chrisgacsal approved these changes

@fishkerez fishkerez Awaiting requested review from fishkerez

@Tehsmash Tehsmash Awaiting requested review from Tehsmash

@akpsgit akpsgit Awaiting requested review from akpsgit

Assignees

@adamtagscherer adamtagscherer

Labels
bug Something isn't working component:api Issues related to API enhancement New feature or request go Pull requests that update Go code
Projects
OpenClarity
Status: Done
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@adamtagscherer @fishkerez @Tehsmash @chrisgacsal @akpsgit