feat(k8s): Discover container images and running containers #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tehsmash
force-pushed
the
k8s_discovery
branch
2 times, most recently
from
98f5e33
to
a321414
Compare
Tehsmash
force-pushed
the
k8s_discovery
branch
3 times, most recently
from
b3f2d4d
to
74197c4
Compare
This comment has been minimized.
This comment has been minimized.
fishkerez
reviewed
Oct 15, 2023
Tehsmash
force-pushed
the
k8s_discovery
branch
from
74197c4
to
bf24955
Compare
This comment has been minimized.
This comment has been minimized.
chrisgacsal
requested changes
Oct 18, 2023
Tehsmash
force-pushed
the
k8s_discovery
branch
from
a54b057
to
9187f49
Compare
This comment has been minimized.
This comment has been minimized.
Tehsmash
force-pushed
the
k8s_discovery
branch
from
9187f49
to
0cd6018
Compare
This comment has been minimized.
This comment has been minimized.
Tehsmash
force-pushed
the
k8s_discovery
branch
2 times, most recently
from
0959382
to
7e02940
Compare
This comment has been minimized.
This comment has been minimized.
Tehsmash
force-pushed
the
k8s_discovery
branch
from
7e02940
to
fe7a7ce
Compare
This comment has been minimized.
This comment has been minimized.
Tehsmash
force-pushed
the
k8s_discovery
branch
from
fe7a7ce
to
fc2819f
Compare
This comment has been minimized.
This comment has been minimized.
Tehsmash
force-pushed
the
k8s_discovery
branch
from
fc2819f
to
3d89fb6
Compare
This comment has been minimized.
This comment has been minimized.
chrisgacsal
reviewed
Nov 2, 2023
There was a problem hiding this comment.
@Tehsmash It looks awesome! I have left a couple comments related to minor things.
Tehsmash
force-pushed
the
k8s_discovery
branch
from
3d89fb6
to
d5e7eea
Compare
Tehsmash
changed the title
This comment has been minimized.
This comment has been minimized.
With this addition the kubernetes provider can now discover container images and running containers from the connected kubernetes cluster. A new Daemonset is introduced which provides entrypoints on each kubernetes node to discover the images and containers running there. The Kubernetes provider will query each instance of the daemonset to create full view of all the containers and images that exist on the kubernetes cluster. The Daemonset supports Docker and ContainerD, other container runtimes can be added in the future through a defined interface.
chrisgacsal
force-pushed
the
k8s_discovery
branch
from
d5e7eea
to
e79edfd
Compare
chrisgacsal
force-pushed
the
k8s_discovery
branch
from
e79edfd
to
d7d41b1
Compare
This comment has been minimized.
This comment has been minimized.
chrisgacsal
previously approved these changes
Dec 4, 2023
* update image name for CR Discovery Server * install CR Discovery Server only if the provider is set to `kubernetes`
chrisgacsal
force-pushed
the
k8s_discovery
branch
from
d7d41b1
to
4cb5117
Compare
chrisgacsal
approved these changes
Dec 4, 2023
|
Hey! Your images are ready:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this addition the kubernetes provider can now discover container images and running containers from the connected kubernetes cluster.
Closes #562
Closes #564
Type of Change
[ ] Bug Fix
[X] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist