Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(yara): run command and parse output line by line #716

Merged
merged 18 commits into from
Oct 2, 2023
Merged

feat(yara): run command and parse output line by line #716

merged 18 commits into from
Oct 2, 2023

Conversation

pbalogh-sa
Copy link
Member

@pbalogh-sa pbalogh-sa commented Sep 27, 2023 •
edited

Description

Instead of running a command and returning byte slice output, this PR addresses parse command output line-by-line during the execution time.

closes: #679

Type of Change

[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[x] Other (please describe) Parse command output line by line in case of yara.

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@pbalogh-sa pbalogh-sa changed the title chore: run command and parse output line by line run command and parse output line by line Sep 27, 2023
@pbalogh-sa pbalogh-sa changed the title run command and parse output line by line Run command and parse output line by line Sep 27, 2023
@pbalogh-sa pbalogh-sa marked this pull request as ready for review September 27, 2023 15:12
@pbalogh-sa pbalogh-sa requested a review from a team as a code owner September 27, 2023 15:12
Tehsmash
Tehsmash requested changes Sep 28, 2023
View reviewed changes
pkg/shared/utils/utils.go Outdated Show resolved Hide resolved
pkg/shared/families/malware/yara/yara.go Outdated Show resolved Hide resolved
pkg/shared/utils/utils.go Outdated Show resolved Hide resolved
pkg/shared/utils/utils.go Outdated Show resolved Hide resolved
@pbalogh-sa pbalogh-sa changed the title Run command and parse output line by line feat(yara): run command and parse output line by line Sep 28, 2023
Tehsmash
Tehsmash reviewed Sep 28, 2023
View reviewed changes
pkg/shared/utils/utils.go Show resolved Hide resolved
pkg/shared/utils/utils.go Outdated Show resolved Hide resolved
FrimIdan
FrimIdan approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@FrimIdan FrimIdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pbalogh-sa pbalogh-sa added this pull request to the merge queue Oct 2, 2023
Merged via the queue into main with commit 436fea1 Oct 2, 2023
10 checks passed
@pbalogh-sa pbalogh-sa deleted the command-output-line-by-line branch October 2, 2023 12:05
@chrisgacsal chrisgacsal mentioned this pull request Nov 6, 2023
Merged
7 tasks
@chrisgacsal chrisgacsal mentioned this pull request Feb 21, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tehsmash Tehsmash Tehsmash approved these changes

@FrimIdan FrimIdan FrimIdan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
OpenClarity
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helper function for run commands and parse their output.
3 participants
@pbalogh-sa @Tehsmash @FrimIdan