Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: raw yara rule sources #725

Merged
merged 12 commits into from
Oct 3, 2023
Merged

feat: raw yara rule sources #725

merged 12 commits into from
Oct 3, 2023

Conversation

pbalogh-sa
Copy link
Member

@pbalogh-sa pbalogh-sa commented Sep 29, 2023 •
edited

Description

This PR adds support for the cli to download raw yara sources using the yara-rule-server package https://github.com/openclarity/yara-rule-server/blob/d4fcd75f7e2daaa0079dca6db23c79b07533269e/pkg/rules/rules.go#L32

First, we need to merge the yara-rule-server PR (openclarity/yara-rule-server#18) that makes the cache dir configurable. Issue: openclarity/yara-rule-server#16

Type of Change

[ ] Bug Fix
[x] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@pbalogh-sa pbalogh-sa marked this pull request as ready for review September 29, 2023 11:22
@pbalogh-sa pbalogh-sa requested a review from a team as a code owner September 29, 2023 11:22
Tehsmash
Tehsmash reviewed Oct 2, 2023
View reviewed changes
Copy link
Contributor

@Tehsmash Tehsmash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I think it would be nice to fix the cache dir and rule path stuff before we merge this into VMClarity, I'm not sure I like to merge something that requires root. WDYT?

akpsgit
akpsgit previously approved these changes Oct 2, 2023
View reviewed changes
@pbalogh-sa pbalogh-sa marked this pull request as draft October 2, 2023 16:38
@pbalogh-sa pbalogh-sa marked this pull request as ready for review October 3, 2023 08:28
@pbalogh-sa pbalogh-sa added this pull request to the merge queue Oct 3, 2023
Merged via the queue into main with commit d29f746 Oct 3, 2023
10 checks passed
@pbalogh-sa pbalogh-sa deleted the raw-yara-rule-sources branch October 3, 2023 12:04
@chrisgacsal chrisgacsal mentioned this pull request Nov 6, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tehsmash Tehsmash Tehsmash approved these changes

@akpsgit akpsgit akpsgit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
OpenClarity
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pbalogh-sa @Tehsmash @akpsgit