fix(docker): run docker from within the container #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tehsmash
previously requested changes
Oct 9, 2023
This comment has been minimized.
This comment has been minimized.
fishkerez
force-pushed
the
fix-docker-sock
branch
from
4c5ec90
to
76c8b7e
Compare
This comment has been minimized.
This comment has been minimized.
|
Hey! Your images are ready:
|
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When I run docker on my computer (Mac, Intel chip) I can see the discovery of assets fails due to:
Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?We need to mount the docker socket in order to connect to the daemon service from within a container.
Type of Change
[x] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)