Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(provider): wrong container image name #772

Merged
merged 7 commits into from
Oct 13, 2023
Merged

fix(provider): wrong container image name #772

merged 7 commits into from
Oct 13, 2023

Conversation

paralta
Copy link
Contributor

@paralta paralta commented Oct 11, 2023 •
edited

Description

The Container Image name is available inside the RepoTag field. Included in this PR:

  • Make container and container image id a required field in the API spec
  • Remove prefix slash from container name
  • Replace image name with repotags and repodigest fields
  • Add container info and container image info to UI asset type items
  • Extend basic test to scan a docker image

Related to #763, but does not fix UI issue.

Type of Change

[x] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@paralta paralta added component:api Issues related to API provider:docker Issues related to the docker provider blocked labels Oct 11, 2023
@paralta paralta self-assigned this Oct 11, 2023
@paralta
Copy link
Contributor Author

paralta commented Oct 11, 2023 •
edited

Currently looking into the new test failure related with the filter used 👀

@github-actions

This comment has been minimized.

Sign in to view
fishkerez
fishkerez reviewed Oct 12, 2023
View reviewed changes
api/openapi.yaml Outdated Show resolved Hide resolved
fishkerez
fishkerez reviewed Oct 12, 2023
View reviewed changes
api/openapi.yaml Outdated Show resolved Hide resolved
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@paralta paralta marked this pull request as ready for review October 12, 2023 11:36
@paralta paralta requested a review from a team as a code owner October 12, 2023 11:36
@paralta paralta removed the blocked label Oct 12, 2023
chrisgacsal
chrisgacsal previously approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@chrisgacsal chrisgacsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@github-actions

This comment has been minimized.

Sign in to view
@chrisgacsal chrisgacsal self-requested a review October 12, 2023 13:07
Tehsmash
Tehsmash requested changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@Tehsmash Tehsmash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Erez's points, lets get those fixed otherwise LGTM.

Tehsmash
Tehsmash requested changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@Tehsmash Tehsmash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Erez's points, lets get those fixed otherwise LGTM.

@paralta paralta force-pushed the fix-container-image branch 3 times, most recently from 834c963 to a962cc9 Compare October 12, 2023 14:15
@github-actions

This comment has been minimized.

Sign in to view
@paralta paralta force-pushed the fix-container-image branch 2 times, most recently from aa46b14 to 45ed389 Compare October 12, 2023 17:03
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr772-d772eafe94d4a920f0f9072f0e230b4d699bf444
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr772-d772eafe94d4a920f0f9072f0e230b4d699bf444
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr772-d772eafe94d4a920f0f9072f0e230b4d699bf444
  • ghcr.io/openclarity/vmclarity-ui-dev:pr772-d772eafe94d4a920f0f9072f0e230b4d699bf444
  • ghcr.io/openclarity/vmclarity-cli-dev:pr772-d772eafe94d4a920f0f9072f0e230b4d699bf444

@paralta paralta added this pull request to the merge queue Oct 13, 2023
Merged via the queue into main with commit eafacae Oct 13, 2023
32 checks passed
@paralta paralta deleted the fix-container-image branch October 13, 2023 11:04
pbalogh-sa pushed a commit that referenced this pull request Oct 16, 2023
@paralta @pbalogh-sa
fix(provider): wrong container image name (#772)
9525e08 
* feat(api): make container and image id required

* feat(provider): remove slash from container name

* feat(provider): replace image name with repotags and repodigest

* feat(provider): add container and image info to asset type

* refactor(provider): code review changes

* test(provider): test image asset is found and scanned

* refactor(provider): code review changes
@chrisgacsal chrisgacsal mentioned this pull request Nov 6, 2023
Merged
7 tasks
@chrisgacsal chrisgacsal mentioned this pull request Feb 21, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tehsmash Tehsmash Tehsmash approved these changes

@chrisgacsal chrisgacsal Awaiting requested review from chrisgacsal

@fishkerez fishkerez Awaiting requested review from fishkerez

Assignees

@paralta paralta

Labels
component:api Issues related to API provider:docker Issues related to the docker provider
Projects
OpenClarity
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@paralta @Tehsmash @chrisgacsal @fishkerez