Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bump go version to 1.21 #792

Merged
merged 1 commit into from
Oct 13, 2023
Merged

feat: bump go version to 1.21 #792

merged 1 commit into from
Oct 13, 2023

Conversation

chrisgacsal
Copy link
Contributor

@chrisgacsal chrisgacsal commented Oct 13, 2023 •
edited

Description

  • bump Golang version to 1.21 for all the packages beside api
  • keep Golang version for api package at version 1.20 in order to avoid forcing users to bump Golang versions to version 1.21
  • add .go-version file to each package root to allow setting Golang version on package level

Type of Change

[ ] Bug Fix
[x] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@chrisgacsal chrisgacsal self-assigned this Oct 13, 2023
@chrisgacsal chrisgacsal marked this pull request as ready for review October 13, 2023 13:19
@chrisgacsal chrisgacsal requested a review from a team as a code owner October 13, 2023 13:19
@github-actions
Copy link

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr792-75cb768520c24c122366e6f110f812979d90703e
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr792-75cb768520c24c122366e6f110f812979d90703e
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr792-75cb768520c24c122366e6f110f812979d90703e
  • ghcr.io/openclarity/vmclarity-ui-dev:pr792-75cb768520c24c122366e6f110f812979d90703e
  • ghcr.io/openclarity/vmclarity-cli-dev:pr792-75cb768520c24c122366e6f110f812979d90703e

@chrisgacsal chrisgacsal added this pull request to the merge queue Oct 13, 2023
Merged via the queue into main with commit d102053 Oct 13, 2023
32 checks passed
@chrisgacsal chrisgacsal deleted the bump-go-version branch October 13, 2023 13:48
@chrisgacsal chrisgacsal mentioned this pull request Nov 6, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tehsmash Tehsmash Tehsmash approved these changes

Assignees

@chrisgacsal chrisgacsal

Labels
None yet
Projects
OpenClarity
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chrisgacsal @Tehsmash