fix(postgres): Ensure that we use the correct JSON sql for delete by ID #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code in deleteById was not using the SQLVariant logic to switch between the Postgres and SQLite versions of JSON extract and JSON quote this resulted in a 500 error when deleting an object through the API. This commit switches to use the SQLVariant variable to generate the correct SQL command to query the ID.
|
Hey! Your images are ready:
|
akpsgit
approved these changes
Oct 18, 2023
chrisgacsal
approved these changes
Oct 18, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The code in deleteById was not using the SQLVariant logic to switch between the Postgres and SQLite versions of JSON extract and JSON quote this resulted in a 500 error when deleting an object through the API.
This commit switches to use the SQLVariant variable to generate the correct SQL command to query the ID.
Closes #820
Type of Change
[X] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist