Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): separate asset drilldown types #860

Merged
merged 9 commits into from
Oct 31, 2023

Conversation

gallotamas
Copy link
Contributor

@gallotamas gallotamas commented Oct 27, 2023

Description

Fix for #804
Create separate details views for the different asset types and only show the relevant fields of specific types.

Screenshots for the different asset types (I don't have a PodInfo and DirInfo asset so I couldn't create a screenshot for them but the views have been updated for them as well):
VMInfo:
image

ContainerInfo:
Screenshot 2023-10-27 at 17 45 36

ContainerImageInfo:
Screenshot 2023-10-27 at 17 46 08

Type of Change

[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[x] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@gallotamas gallotamas requested a review from a team as a code owner October 27, 2023 12:19
@gallotamas
Copy link
Contributor Author

@Tehsmash @chrisgacsal I've updated the asset details view. Let me know what you think.

@github-actions

This comment has been minimized.

@Tehsmash
Copy link
Contributor

Looking good so far @gallotamas! Couple of feedback items:

  • For ContainerImageInfo I'd like to see the RepoTags and RepoDigests closer together, and presented so that it appears a list. (if we can prevent line wrapping too by including them on their own row in the box that would be even better too)

  • For ContainerInfo it would be good to have all the ContainerImageInfo as a subsection/ under a subheading and mimic the ContainerImageInfo page as closely as possible.

@gallotamas
Copy link
Contributor Author

Looking good so far @gallotamas! Couple of feedback items:

  • For ContainerImageInfo I'd like to see the RepoTags and RepoDigests closer together, and presented so that it appears a list. (if we can prevent line wrapping too by including them on their own row in the box that would be even better too)
  • For ContainerInfo it would be good to have all the ContainerImageInfo as a subsection/ under a subheading and mimic the ContainerImageInfo page as closely as possible.

sounds good, thanks for the feedback @Tehsmash

@gallotamas
Copy link
Contributor Author

@Tehsmash I made some changes based on your feedback. Can you take another look?

@github-actions

This comment has been minimized.

@gallotamas gallotamas changed the title Separate asset drilldown types fix(ui): separate asset drilldown types Oct 30, 2023
chrisgacsal
chrisgacsal previously approved these changes Oct 30, 2023
Copy link
Contributor

@chrisgacsal chrisgacsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Although I have not tested it. @Tehsmash @akpsgit wdyt?

@github-actions

This comment has been minimized.

adamtagscherer
adamtagscherer previously approved these changes Oct 30, 2023
@github-actions
Copy link

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr860-20bd8f90c426f6ad79b4a3bbb84eaab3b70259cf
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr860-20bd8f90c426f6ad79b4a3bbb84eaab3b70259cf
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr860-20bd8f90c426f6ad79b4a3bbb84eaab3b70259cf
  • ghcr.io/openclarity/vmclarity-ui-dev:pr860-20bd8f90c426f6ad79b4a3bbb84eaab3b70259cf
  • ghcr.io/openclarity/vmclarity-cli-dev:pr860-20bd8f90c426f6ad79b4a3bbb84eaab3b70259cf

@gallotamas gallotamas linked an issue Oct 30, 2023 that may be closed by this pull request
Merged via the queue into main with commit dbce9a3 Oct 31, 2023
32 checks passed
@gallotamas gallotamas deleted the separate-asset-drilldown-types branch October 31, 2023 08:32
@chrisgacsal chrisgacsal mentioned this pull request Nov 6, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Create separate Asset drill-down screens per asset type
4 participants