Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Improved formatting for exploits and vulnerabilities in asset scan details #891

Merged
merged 4 commits into from
Nov 2, 2023

Conversation

gallotamas
Copy link
Contributor

@gallotamas gallotamas commented Nov 2, 2023

Description

Fix for #812 and #813

Change the labels for csv input types. Add component that support showing X number of lines of text with ellipses (... sign) at the end. Use this component to display the content of the csv. Add a show more arrow button that is only visible if there are more than X lines of text and you can also shrink it after you expanded it. (In this case X=5 but it can easily be changed if needed.)
Update the duration calculation to show the text less than 1 second if the start time equals with the end time.

Screenshot:
image

Type of Change

[x] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

This comment has been minimized.

Copy link

github-actions bot commented Nov 2, 2023

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr891-d218beebd07c713ecb6829f63d5c05b6e418d2dc
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr891-d218beebd07c713ecb6829f63d5c05b6e418d2dc
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr891-d218beebd07c713ecb6829f63d5c05b6e418d2dc
  • ghcr.io/openclarity/vmclarity-ui-dev:pr891-d218beebd07c713ecb6829f63d5c05b6e418d2dc
  • ghcr.io/openclarity/vmclarity-cli-dev:pr891-d218beebd07c713ecb6829f63d5c05b6e418d2dc

@gallotamas gallotamas added this pull request to the merge queue Nov 2, 2023
Merged via the queue into main with commit fe34906 Nov 2, 2023
32 checks passed
@gallotamas gallotamas deleted the better-formatting-for-exploits branch November 2, 2023 15:17
@chrisgacsal chrisgacsal mentioned this pull request Nov 6, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
2 participants