-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auth grant flow #117
auth grant flow #117
Conversation
Hi @peterdudfield , this code follows the auth grant flow as required for enphase v4, can you please review this then we can proceed with the testing, Ive made it modular so that you can test it too! |
Have you tested this? |
I will in a bit, ill need some info like enphase system id etc, will be asking you through email for those info |
Hi @peterdudfield , this commit successfully generates access token for the api to fetch the summary of a site, next steps would be to utilize these tokens and fetch the summary |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
==========================================
- Coverage 79.94% 73.94% -6.00%
==========================================
Files 12 13 +1
Lines 354 426 +72
==========================================
+ Hits 283 315 +32
- Misses 71 111 +40 ☔ View full report in Codecov by Sentry. |
What are these failures in codecov? are they about the test coverages? or is it something else |
Hi @Sukh-P , I have made some changes here that ensures the auth grant flow works and made the example code more modular to keep it as it was before creating the enphase directory to function normally until we thoroughly test the enphase files, this can be merged , if you could review it that would be great |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on getting some power production data back from the Enhpase inverter API! Have a small few comments, mostly about removing some commented out prints but nothing major
Thanks a lot! Ill make the changes and get them merged |
Pull Request
Description
This code is an extension of #106 and implements the authorization grant flow as required by enphase v4
Fixes #
Before it was client credentials grant flow, now it is authorization grant flow
Checklist: