Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Pytest for all tests #229

Closed
jacobbieker opened this issue Mar 6, 2024 · 6 comments · Fixed by #242
Closed

Use Pytest for all tests #229

jacobbieker opened this issue Mar 6, 2024 · 6 comments · Fixed by #242
Assignees
@norbline
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jacobbieker
Copy link
Member

We would like to have all our tests use pytest, rather than some using unittest.

Context

Most other repos use pytest, so would nice to be consistent.

Possible Implementation

Replace the unittest framework in the tests with pytest
@jacobbieker jacobbieker added enhancement New feature or request good first issue Good for newcomers labels Mar 6, 2024
@norbline
Copy link
Contributor

norbline commented Mar 6, 2024

@jacobbieker, Can I be assign to this issue?

@jacobbieker
Copy link
Member Author

Yes!

norbline added a commit to norbline/Satip that referenced this issue Mar 6, 2024
@norbline
fixes openclimatefix#229 use Pytest for all tests
74b4796
@vikasgrewal16
Copy link

Can i get some inputs on this issue and what is the remaining work @jacobbieker @norbline

@vikasgrewal16
Copy link

can i get your insights what is done and what is needed to be done? @norbline

@jacobbieker
Copy link
Member Author

@vikasgrewal16 I think @norbline has it going so far, if you want to take #231 that would be great!

@vikasgrewal16
Copy link

Thanks @jacobbieker I have been working on #231 and will get to you as soon as possible

@norbline norbline mentioned this issue Mar 26, 2024
Merged
jacobbieker pushed a commit that referenced this issue Mar 26, 2024
@norbline @pre-commit-ci
fixes #229 use Pytest for all tests (#242)
d62685d 
* fixes #229 use Pytest for all tests

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@jacobbieker jacobbieker mentioned this issue Mar 26, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@norbline norbline

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes #229 use Pytest for all tests norbline/Satip
3 participants
@jacobbieker @norbline @vikasgrewal16